search

deltachat / provider-db

Database of Email Providers and how well they work with DeltaChat
https://providers.delta.chat
Mozilla Public License 2.0
53 stars 33 forks source link

`strict_tls` moved to `opts`? #285

Closed WofWca closed 7 months ago

WofWca commented 7 months ago

I see 3c8f7e846c915a183dc44536fb5480d1f25d7c42 moved it to opts, but it's still not removed from top-level from

https://github.com/deltachat/provider-db/blob/3c8f7e846c915a183dc44536fb5480d1f25d7c42/validation/index.js#L87

and

https://github.com/deltachat/provider-db/blob/8d3ce6d1f3e6bde1e6d092849184e1d2ebe961c9/README.md#L45

Also some providers still specify it at top-level, namely these two recently added ones:

https://github.com/deltachat/provider-db/blob/5b35f7b87103fa0895fdc471769386113371688d/_providers/mehl.cloud.md#L17

https://github.com/deltachat/provider-db/blob/5b35f7b87103fa0895fdc471769386113371688d/_providers/daleth.cafe.md#L17

Is it ok or nah?

iequidoo commented 7 months ago

It's not ok, i forgot to remove strict_tls from https://github.com/deltachat/provider-db/blob/3c8f7e846c915a183dc44536fb5480d1f25d7c42/validation/index.js#L87 and https://github.com/deltachat/provider-db/blob/8d3ce6d1f3e6bde1e6d092849184e1d2ebe961c9/README.md#L45 and that's the reason why it appeared in the new provider files. So, it should be removed from there (although that actually changes nothing)