search

deltaluca / nape

Haxe/AS3 Physics Engine
http://napephys.com
Other
542 stars 77 forks source link

Update property declaration syntax for Haxe 4 compatibility #114

Open Gama11 opened 5 years ago

Gama11 commented 5 years ago

see HaxeFoundation/haxe#4699 - Haxe 4 removes support for the old Haxe 2 style property syntax, so trying to compile Nape with it leads to a bunch of errors:

C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2.hx:641: characters 2-50 : length: Custom property accessor is no longer supported, please use set
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2.hx:921: characters 2-47 : angle: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2.hx:921: characters 2-47 : angle: Custom property accessor is no longer supported, please use set
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/dynamics/ArbiterList.hx:248: characters 2-43 : length: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/geom/Vec2List.hx:248: characters 2-43 : length: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/constraint/Constraint.hx:197: characters 2-60 : userData: Custom property accessor is no longer supported, please use get
C:/HaxeToolkit/haxe/lib/nape/2,0,20/nape/constraint/Constraint.hx:224: characters 2-65 : compound: Custom property accessor is no longer supported, please use get

@deltaluca If you want to make a release right away, here's a .zip with an updated haxelib.json and rebuilt sources: 2,0,21.zip

trethaller commented 5 years ago

Cheers Jens, we're also using Nape here at Shiro 👍

peteshand commented 5 years ago

Would be great to have this deployed to haxelib!

TomByrne commented 5 years ago

+1 For getting this on Haxelib

Gama11 commented 5 years ago

Since there's quite a few signs that Luca is no longer interested in maintaining Nape (no responses to issues, PRs or emails, the domain has expired...), I've created a fork and pushed it it to Haxelib.

So to get a Haxe 4 compatible version, you just have to replace the library name in your .hxml / project.xml with nape-haxe4 and run haxelib install nape-haxe4.

peteshand commented 5 years ago

nice one @Gama11