search

deltanet / adapt-contrib-xapi

TinCan/xAPI extension for the Adapt Framework
GNU General Public License v3.0
0 stars 0 forks source link

Duplicate course:complete and course:failed statements can be sent in some circumstances #29

Open deltanetdan opened 2 years ago

deltanetdan commented 2 years ago

xAPI courses setup with the following will send a course:complete and a course:failed statements

    "contentObjects": {"change:_isComplete": true}
    "_requireContentCompleted": false,
    "_requireAssessmentCompleted": true

This can confuse some LRS's. FW v5 just sent one statement for the course definition.

It is sending a definition: course, verb: completed statement when the last contentObject is completed. A user would expect that contentoObject definitions only would be controlled by the contentObject: true/false toggle.

Should the definition for this be page/menu?

FW v5.18.2 (deltanet fork) xAPI v0.8.8 (deltanet fork)