search

deltaphc / raylib-rs

Rust bindings for raylib
Other
715 stars 123 forks source link

Updates from_euler parameter names to match raymath's QuaternionFromEuler #178

Closed LoparPanda closed 1 month ago

LoparPanda commented 5 months ago

This change reflects the fix done in https://github.com/raysan5/raylib/issues/1651. I found from_euler was not behaving as expected when changing yaw, pitch, and roll for a 3d camera. When I provide values in the the same order now used in raymath (pitch, yaw, roll), rotation behavior is as expected.

Dacode45 commented 5 months ago

Can you change this pr to merge into the 5.0 branch?

LoparPanda commented 5 months ago

Sure thing. Which branch would you like me to merge into? I didn't see an obvious one for 5.0.

o-dka commented 2 months ago

Sure thing. Which branch would you like me to merge into? I didn't see an obvious one for 5.0.

Hello, I think what they meant is to merge this pr into this branch , it's on a different repository.