search

deltazefiro / Amarok-Hider

Hide your private files and apps with a single click.
https://deltazefiro.github.io/Amarok-doc/en-US/
Apache License 2.0
1.34k stars 46 forks source link

[BUG] There is no trigger on media rescan after .nomedia hide/unhide method #146

Closed FinecoFinit closed 2 months ago

FinecoFinit commented 2 months ago

Describe the bug / 问题描述 Media is still visible after adding .nomedia file

Expected behavior / 预期行为 .nomedia file should be created and media rescan called

Basic Information (please complete the following information) / 请填写以下信息:

deltazefiro commented 2 months ago

Apologize for the late response. Made a fix.
Please try out this version.

FinecoFinit commented 2 months ago

@deltazefiro Works! But media store might be slow on rescan, I switch the app and pictures still there for a few seconds, I think better add progress bar until media store rescan finishes its job

deltazefiro commented 2 months ago

Works!

Great to hear! Thanks for the timely feedback.

I think better add progress bar until media store rescan finishes its job

I prefer to keep it quiet in the background. The media store scanning process is carried out by the system, not Amarok. Amarok only sends a message to the system to trigger the rescan. Adding a progress bar in Amarok that shows the system's progress could be misleading and nonintuitive.

FinecoFinit commented 2 months ago

Well then, lgtm