search

deltazefiro / Amarok-Hider

Hide your private files and apps with a single click.
https://deltazefiro.github.io/Amarok-doc/en-US/
Apache License 2.0
1.34k stars 46 forks source link

[BUG] F-Droid can't build #160

Closed licaon-kter closed 3 weeks ago

licaon-kter commented 3 weeks ago

xposed lib is not available in a trusted maven repo

> Task :app:processFossReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:processFossReleaseResources'.
> Could not resolve all files for configuration ':app:fossReleaseCompileClasspath'.
   > Could not find de.robv.android.xposed:api:82.
     Searched in the following locations:
       - https://dl.google.com/dl/android/maven2/de/robv/android/xposed/api/82/api-82.pom
       - https://repo.maven.apache.org/maven2/de/robv/android/xposed/api/82/api-82.pom
       - https://jitpack.io/de/robv/android/xposed/api/82/api-82.pom
     Required by:
         project :app

ref: https://github.com/deltazefiro/Amarok-Hider/commit/e1d1f1e43997eec7b712a2e8c92cd841942baf67

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/3682805926959d87c6d530d3dd4eeb32f67b6aa8

deltazefiro commented 3 weeks ago

Hi @licaon-kter I imported the Xposed library from the official Xposed API repository at https://api.xposed.info/. I believe it's a common requirement for every xposed module. Any suggestions for removing it?

licaon-kter commented 3 weeks ago

Maybe we can build it from source? Since this is a repro app... I guess you might need to build it too :( :)

Any suggestions for removing it?

move the xposed stuff out of the foss flavor :shrug:

deltazefiro commented 3 weeks ago

@licaon-kter Well, I found that the Xposed library can also be obtained from jcenter, although it is deprecated. I will create a new release without https://api.xposed.info/ :D

EDIT: New release published v0.9.1

licaon-kter commented 3 weeks ago

That fixes it https://gitlab.com/fdroid/fdroiddata/-/commit/8cfa2753b36958f04ddf6fe6fc75ebf7677dc04d

jcenter, although it is deprecated

good luck to future you when the time comes and that is unreachable :shrug:

deltazefiro commented 3 weeks ago

good luck to future you when the time comes and that is unreachable 🤷

☹️ There's another solution: we can include the .jar library in the source tree. However, as per F-Droid Inclusion Policy:

Binary dependencies such as JAR files have to be built from source or installed from Debian repos.

I'm not sure if I can do this. I found that Scoop did so and got included in F-Droid, so I believe it's OK, right?

licaon-kter commented 3 weeks ago

Not true, those are not used: https://gitlab.com/fdroid/fdroiddata/-/blob/master/metadata/taco.scoop.yml#L87

But https://github.com/TacoTheDank/Scoop/blob/v2.4.2/build.gradle#L9