search

deltazefiro / Amarok-Hider

Hide your private files and apps with a single click.
https://deltazefiro.github.io/Amarok-doc/en-US/
Apache License 2.0
1.54k stars 50 forks source link

[BUG] Files with long filenames are not hidden. #178

Open chrome99001 opened 1 month ago

chrome99001 commented 1 month ago

As per title. Had a file with 73 characters in the filename and Amarok won't hide it. It is still viewable in the video player app. I reduced the filename to 68 characters, then only was it hidden.

*Edit: Just noticed that it only happens to certain files. I've checked and some of the files with 100 over characters are not affected.

deltazefiro commented 1 month ago

Hi @chrome99001 Thank you for letting me know. I have confirmed the issue.

Amarok obfuscates the filename with base64 when hiding. The encoded filenames are generally longer than the original ones. Android has a filename length limit of 255 characters, thus when the encoded names are longer than 255, the obfuscation fails.

Unless changing how we obfuscate file names, this issue might be tricky to fix. A possible solution is to write the filename into the original file. I'm afraid I can not fix it soon, but let me put it into our project's to-do list.