deltazefiro / Amarok-Hider

Hide your private files and apps with a single click.
https://deltazefiro.github.io/Amarok-doc/en-US/
Apache License 2.0
1.54k stars 50 forks source link

[Enhancement] Quick panel concerns #51

Open ae5960e8-a6fc-491f-b252-898ecf59af95 opened 1 year ago

ae5960e8-a6fc-491f-b252-898ecf59af95 commented 1 year ago

The quick panel feature which let's us enable and disable privacy is very useful but I see some problems with it. It is (1)accessable from the lock screen which is not ideal because anyone who finds the device will know Amarok is installed. (2)They can also toggle privacy from the lock screen.

  1. I suggest renaming the quick panel toggle to something generic like "Display mode". Active means privacy is disabled and Inactive means privacy is enabled. This means Amarok will be hard to detect.

  2. I also suggest making the quick panel toggle require the device to be unlocked so it can't be toggled from the lock screen. This means privacy cannot be disabled by someone else from the lock screen.

deltazefiro commented 1 year ago

I also suggest making the quick panel toggle require the device to be unlocked so it can't be toggled from the lock screen. This means privacy cannot be disabled by someone else from the lock screen.

Fixed.

I suggest renaming the quick panel toggle to something generic like "Display mode". Active means privacy is disabled and Inactive means privacy is enabled. This means Amarok will be hard to detect.

I may implement it in the next major version, if possible.

Thanks.

HarriBuh commented 1 year ago

Another major issue here is that I can unlock Amarok via Quick panel even with the latest lock feature enabled. I enabled both password and biometric lock and while I now have to unlock the app whenever I open the app from the app list, I am able to easily un- and relock the app from the Quick panel without any security measures!

deltazefiro commented 1 year ago

@HarriBuh Known bug :wink: WIP

deltazefiro commented 1 year ago

@HarriBuh

Another major issue here is that I can unlock Amarok via Quick panel even with the latest lock feature enabled.

Done. See the CI-built version.

HarriBuh commented 1 year ago

Great to hear! Looking forward to the official release then.