search

deltazefiro / Amarok-Hider

Hide your private files and apps with a single click.
https://deltazefiro.github.io/Amarok-doc/en-US/
Apache License 2.0
1.35k stars 46 forks source link

[FeatureRequest] Let us choose Dark/Light themes manually #91

Open JFMugen opened 10 months ago

JFMugen commented 10 months ago

I am assuming "Dynamic Color" setting changes Dark/Light mode but in my case there is no Dark theme of the phone (Huawei P9 Lite - Android 8) so it is always Light theme.

Letting us choose Dark/Light theme options can fix this issue.

LLinlll commented 8 months ago

@deltazefiro Hi,is this issue still available?Can I take this?Please assign to me.

deltazefiro commented 8 months ago

@LLinlll :clap:

Hi,is this issue still available?Can I take this?Please assign to me.

Certainly! Thanks for your interest! Feel free to open a PR once you are done!

LLinlll commented 8 months ago

@deltazefiro I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page? Although I'd prefer to be on the main page, the setting page seems too crowded.

JFMugen commented 8 months ago

@deltazefiro I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page? Although I'd prefer to be on the main page, the setting page seems too crowded.

I think it would make sense to put it just below "Dynamic Color" setting.

LLinlll commented 8 months ago

@deltazefiro I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page? Although I'd prefer to be on the main page, the setting page seems too crowded.

I think it would make sense to put it just below "Dynamic Color" setting.

Sorry，I did not find where is the"Dynamic Color" setting.

JFMugen commented 8 months ago

Sorry，I did not find where is the"Dynamic Color" setting.

It's part of "Misc" settings.

deltazefiro commented 8 months ago

I would like to ask if I can add a button to change the theme directly on the main page, or would you prefer it to be on the setting page?

I'd suggest placing it beneath the "Dynamic Color" option in the setting page.
Android 10 introduced a global dark theme switch. Since over 70% of Android users have Android 10 or newer, switching themes isn't frequent enough to warrant a spot on the main page.

the setting page seems too crowded.

Absolutely! I'm planning a refactor to divide the settings across multiple pages and use data binding for enhanced maintainability. Perhaps in v0.10.

SagXD commented 5 months ago

Any Update on this? Also one more suggestion add a Pure Black Theme for Amoled Device User which can save some battery. Thanks

SagXD commented 5 months ago

@LLinlll Hey , Are you working on this PR?