UI Tweaks

[jacobdalamb]

• Change @{username}’s Achievements to Achievements as the username is already displayed at the top
• Add hover state to badge picker
• Add {repoCount} next to stat bar
• Place user's GitHub link in title

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
astro-badge	✅ Ready (Inspect)	Visit Preview	Oct 19, 2023 4:46pm

[delucis]

Thanks for this PR @jacobthesheep! I don‘t think we actually want to make most of these tweaks though.

To quickly go over things:

• Change @{username}’s Achievements to Achievements as the username is already displayed at the top

I can follow the logic here, but I actually quite like seeing “X’s Achievements” spelled out as it is currently.

• Add hover state to badge picker

I don’t love how the rounded buttons touch when adding this hover state. Guess we could try something else, but as it stands, I’d stick with what we have currently.

• Add {repoCount} next to stat bar

This is pretty visually noisy and I don’t think the point of these graphs is to indicate precise numbers, more the distribution of things across repos, so I’d rather not add these. (The way this change is currently implemented also means the number is repeated for screenreader users, for example “astro 662 pulls (662)”.)

• Place user's GitHub link in title

I don’t really follow why this change was made — it seems more confusing than the current GitHub icon approach, as I don’t think I’d expect clicking the title of a page to take me to a different website.

Given all this, I’m going to go ahead and close this PR. For future tweaks like this is might be helpful to open an issue with your ideas first so we can chat about them — would also likely help us build context for why changes are being made, which isn’t always clear without some prior discussion.

Thanks again!