search

delucis / astro-embed

Low-JavaScript embed components for Astro websites
https://astro-embed.netlify.app
MIT License
166 stars 24 forks source link

Image optimization process #111

Open sas-news opened 3 months ago

sas-news commented 3 months ago

Add a downloadPoster prop to YouTube and Vimeo and LinkPreview components. Download images at build time, using getImage().

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 3cb480c7a93536664b7baa5ce907a3328f046a08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for astro-embed ready!

Name Link
Latest commit 7495ca845fd46bb7eca24fc4e5adcb5a981995e5
Latest deploy log https://app.netlify.com/sites/astro-embed/deploys/660dfd8370486d0008de8d01
Deploy Preview https://deploy-preview-111--astro-embed.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sas-news commented 2 months ago

Correction of image optimization process

This allows local images to work correctly out of the box, while still providing the ability to opt-in to optimization for approved remote domains. LinkPreview component now benefits from the built-in optimization capabilities using astro:assets, while YouTube and Vimeo components use getImage() for optimization.