search

delucis / astro-embed

Low-JavaScript embed components for Astro websites
https://astro-embed.netlify.app
MIT License
166 stars 24 forks source link

@astro-community/astro-embed-vimeo package doesn't list the dependency of @astro-community/astro-embed-utils #112

Closed KristianH closed 3 months ago

KristianH commented 3 months ago

The astro embed Vimeo package has a dependency to astro-embed-utils.

The dependency is imported in packages/astro-embed-vimeo/Vimeo.astro

---
import { safeGet } from '@astro-community/astro-embed-utils';
import urlMatcher from './matcher';

The dependency is missing in the package.json.

Similar to this the astro-embed-link-preview (package.json) or astro-embed-twitter (package.json) has this dependency declared.

  "dependencies": {
    "@astro-community/astro-embed-utils": "^0.1.1"
  }

Note: maybe the version should also set to "^0.1.2"

delucis commented 3 months ago

Good catch! Yes, we should add this to the dependencies.

This is the second time in a week or so that this has happened to different packages. I’m wondering if we should switch to a pnpm monorepo instead as that should error in cases like this instead of how the npm monorepo keeps working locally.