Closed jasikpark closed 5 days ago
Latest commit: 97fb2f36d08e82903fc4d589c6eeb11f79dbd9a8
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
I prefer extra control and positively named props, but I can switch to that if you want π
"positively named props" = showMedia={false}
with a default of true, instead of a don'tShowMedia={true}
which adds a negative in the name
I get that, but if true
is the default, I find they work less nicely.
For example: now thereβs showMedia
prop, do I need to set the showMedia
prop to show media? It sounds like maybe I do. Perhaps I should set showMedia={true}
just to be safe.
Given this is only ever used for hiding media, naming it with the user goal in mind is ideal I think.
btw, I'd reccomend turning on experimentalTernaries
in Prettier, it makes ternary expressions much easier to read IMO
Name | Link |
---|---|
Latest commit | 97fb2f36d08e82903fc4d589c6eeb11f79dbd9a8 |
Latest deploy log | https://app.netlify.com/sites/astro-embed/deploys/66846b55ea211900084979fa |
Deploy Preview | https://deploy-preview-132--astro-embed.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Fixes https://github.com/delucis/astro-embed/issues/129
Tried to be minimally invasive in my edits and add
showImage
andshowVideo
props which should function as if the OG url didn't have an image or video, essentially.