Open sylvinus opened 1 month ago
The YT embed is resistant to invalid video IDs, but the Vimeo one fails with Cannot read properties of undefined (reading 'endsWith').
Cannot read properties of undefined (reading 'endsWith')
This is an issue because someone unpublishing a video can break our builds ...
https://github.com/delucis/astro-embed/blob/96ce82eef9ccbcf228ad2e589d066974899e805f/packages/astro-embed-vimeo/Vimeo.astro#L43
Thanks!
Thanks for the issue @sylvinus! Would be happy to look at a PR to make handling that case more robust.
The YT embed is resistant to invalid video IDs, but the Vimeo one fails with
Cannot read properties of undefined (reading 'endsWith')
.This is an issue because someone unpublishing a video can break our builds ...
https://github.com/delucis/astro-embed/blob/96ce82eef9ccbcf228ad2e589d066974899e805f/packages/astro-embed-vimeo/Vimeo.astro#L43
Thanks!