search

delucis / astro-embed

Low-JavaScript embed components for Astro websites
https://astro-embed.netlify.app
MIT License
189 stars 29 forks source link

Invalid video ID raises exception with Vimeo provider #135

Open sylvinus opened 1 month ago

sylvinus commented 1 month ago

The YT embed is resistant to invalid video IDs, but the Vimeo one fails with Cannot read properties of undefined (reading 'endsWith').

This is an issue because someone unpublishing a video can break our builds ...

https://github.com/delucis/astro-embed/blob/96ce82eef9ccbcf228ad2e589d066974899e805f/packages/astro-embed-vimeo/Vimeo.astro#L43

Thanks!

delucis commented 1 month ago

Thanks for the issue @sylvinus! Would be happy to look at a PR to make handling that case more robust.