delucis / astro-embed

Low-JavaScript embed components for Astro websites
https://astro-embed.netlify.app
MIT License
172 stars 25 forks source link

fix: YouTube embed height in Starlight #71 #74

Closed vasfvitor closed 7 months ago

vasfvitor commented 7 months ago

Hi. I think is supposed to be upstream on lite-youtube, or even Starlight (maybe not as it was already discussed there) in not sure, but I'm opening this here and see where it goes. This aims to solve #71

It basically overrides the CSS that is setting height to auto and margin-top to 1.5rem in Starlight markdown.css: Line 4 and Line 43.

For reference, after these changes:

Thank you.

changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: fd3b28368f830a05f2752f45a7ef75088a91a92d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------------------ | ----- | | @astro-community/astro-embed-youtube | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR