search

delucis / astro-netlify-cms

Integration to add Netlify CMS’s admin dashboard to any Astro project
161 stars 21 forks source link

Add `disableIdentityWidgetInjection` option #33

Closed Marocco2 closed 1 year ago

Marocco2 commented 1 year ago

Check if it compiles nicely as I am not capable of checking it

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: d05ec035f52665a08cedaef3c91a7289d4911498

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | astro-netlify-cms | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Marocco2 commented 1 year ago

Thanks @Marocco2! I’ve left a couple of notes for things that need fixing.

I’m curious: how are you planning to use this? Without the widget injection, is it still possible to log in?

If I've understood correctly, Identity widget is useful for sign up members but for login I can rely on Netlify CMS login page. I'm using a invite-only system and I don't require anymore this widget.

I'll make those changes shortly, so I can try my theory

delucis commented 1 year ago

OK, all went well! You should be able to try this out by installing the next tag:

npm i astro-netlify-cms@next

Would you mind reporting back and saying how you get on? If this works, I’ll release this as the main 0.3.2, and if not we can revert. Thanks!

Marocco2 commented 1 year ago

OK, all went well! You should be able to try this out by installing the next tag:

npm i astro-netlify-cms@next

Would you mind reporting back and saying how you get on? If this works, I’ll release this as the main 0.3.2, and if not we can revert. Thanks!

I can confirm that it works as intended. I can still login with my account without using the widget

delucis commented 1 year ago

Fantastic! I’ll get this released as 0.3.2 then — thanks @Marocco2!