delucis / astro-netlify-cms

Integration to add Netlify CMS’s admin dashboard to any Astro project
161 stars 21 forks source link

add Netlify identity widget on admin route #40

Closed Sacramentix closed 1 year ago

Sacramentix commented 1 year ago

Currently if you don't set disableIdentityWidgetInjection to true then it add the Netlify Identity Widget to all page which can lead to unnecessary ressource being loaded in most case.

I would be nice to have a options to only inject it on admin routes.

delucis commented 1 year ago

Should be feasible. Maybe we could go for something like:

NetlifyCMS({
  injectIdentityWidget: 'site' | 'admin-only' | false
})

This would default to 'site' and replace the current option for disabling the widget injection.

Would you be interested in making a PR?

SeanMcP commented 1 year ago

Is there ever an instance where you wouldn't want identity on the admin page? An alternative might be to keep the current behavior and just include it in the admin-dashboard.astro component.

delucis commented 1 year ago

The contributor who added the feature confirmed they could log in successfully so I guess it can work in certain circumstances?

https://github.com/delucis/astro-netlify-cms/pull/33#issuecomment-1295844449

SeanMcP commented 1 year ago

Good to know! Being able to log in makes sense, but I wonder how you can invite users without the identity script running somewhere on the site to handle the invite_token.

I guess if you add the option, then it is up to the user to handle.

delucis commented 1 year ago

Actually tested this myself and I think comments in #33 may have been misleading. Looks like: if you were already logged in before, logging in again without the identity widget works. But if you are trying to log in for the first time (e.g. with a different browser/device or incognito window), you do need the identity widget to make that work.

Given that, I think your proposal of always including on /admin makes sense until we hear otherwise @SeanMcP 👍

SeanMcP commented 1 year ago

Sounds good. It's a small change, but I would be happy to make it if that would be helpful.

delucis commented 1 year ago

Absolutely — a contribution would be great!

delucis commented 1 year ago

Thanks again for offering to make this change @SeanMcP — decided I needed it myself for a project I was working on so got it implemented and released in v0.3.5 🙌