search

delucis / astro-netlify-cms

Integration to add Netlify CMS’s admin dashboard to any Astro project
160 stars 22 forks source link

Add astro react() integration gotcha to README #52

Closed JasperDeLanghe closed 1 year ago

JasperDeLanghe commented 1 year ago

As suggested in #51

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 7936911ca4fc4ee4915dcfd6971225b28db19332

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/JasperDeLanghe/astro-netlify-cms/new/latest?filename=.changeset/four-wasps-explain.md&value=---%0A%22astro-netlify-cms%22%3A%20patch%0A---%0A%0AAdd%20astro%20react()%20integration%20gotcha%20to%20README%0A)

delucis commented 1 year ago

Thanks for this and #51! I’ve actually been wondering if it makes most sense not to automatically include react() when adding the integration. This behaviour dates back to an early experiment that was much more tied to React components, but I suspect it could now work with or without @astrojs/react. In that case it would be better to leave that choice to each project instead of forcing a specific version of @astrojs/react on them.