search

delucis / bgio-effects

📤 Helpers for managing state effects in boardgame.io
https://delucis.github.io/bgio-effects/
Other
18 stars 9 forks source link

Update react dependency to allow version 18 #568

Open walkerkd opened 1 year ago

walkerkd commented 1 year ago

Currently there is the following dependency in the project.json file:

  "peerDependencies": {
    "boardgame.io": ">=0.42.0",
    "react": "^16 || ^17"
  },

However boardgame.io now works with react version 18 since the 0.50.1. Is there any reason why this dependency could not be updated to include react 18?

on3iro commented 1 year ago

hi - I already created a PR for this, but apparently @delucis does currently not actively maintain this library :( I am considering a fork at this point, but maybe @delucis will chime in before that

on3iro commented 1 year ago

on a side note: even though npm will tell you that the peer dependency is incorrect, you can still use the current version of this library with bgio and react 18 without any issues.

walkerkd commented 1 year ago

I have been successfully using it with react 18 ... the problem is when I want to update all my dependencies with the command npm update it the fails due to this dependency check. I have worked around it for now but it would be much nicer if the dependency was updated.

I think @delucis was probably the last of the active developers of boardgame.io (at least he was the person who responded with help when I started out with boardgame.io). But there have been no changes for quite some time which suggests to me that the main developers have moved onto other things. Which is a pity because I found this a great framework for writing my board games in.