search

delve-team / delve

PyTorch model training and layer saturation monitor
https://delve-docs.readthedocs.io
MIT License
79 stars 13 forks source link

[JOSS review] Incorrect qualifiers #55

Closed dionhaefner closed 2 years ago

dionhaefner commented 2 years ago

Qualifiers in setup.py:

        'Programming Language :: Python :: 3.4',
        'Programming Language :: Python :: 3.5',
        'Programming Language :: Python :: 3.6',

But since you have python_requires='>=3.6', this should probably be something like 3.6 through 3.10.

(This is a part of the ongoing review at openjournals/joss-reviews#3992)

JustinShenk commented 2 years ago

Thanks! Fixed in https://github.com/delve-team/delve/commit/70b6ddb290622a1938cf4ea3bcf6da6c1b25d268, closing.