Replacing WebSockets with Comet

delving / culture-hub

The Delving Search and Administrative Interface

Apache License 2.0

66 stars 5 forks source link

Replacing WebSockets with Comet #941

Closed manuelbernhardt closed 10 years ago

manuelbernhardt commented 10 years ago

infinite iframe technique with long-lasting connection
alerting users when the connection dies
subscribers are removed if they don't ping the server in a given time-frame
some browsers will display a forever loading wheel on the page, but this is the only technology that will work across all browsers & connections

geralddejong commented 10 years ago

I fetched the branch and tried it out. It makes my browser think that it is constantly loading, which is weird because the mouse has the pause icon (Linux) everywhere.

manuelbernhardt commented 10 years ago

Unfortunately that's how Comet works. Feel free to Google it.

On Friday, November 22, 2013, Gerald de Jong wrote:

I fetched the branch and tried it out. It makes my browser think that it is constantly loading, which is weird because the mouse has the pause icon (Linux) everywhere.

— Reply to this email directly or view it on GitHubhttps://github.com/delving/culture-hub/pull/941#issuecomment-29083709 .

geralddejong commented 10 years ago

Ok then comet sucks too, unless there's something surmountable keeping us from enjoying the pleasures of websockets.

manuelbernhardt commented 10 years ago

The mouse works fine on OS X, and from what I know of Comet, on Windows as well. I don't think a majority of the people using the DataSet page uses Linux.

The "forever loading" sign on the browser may be an inconvenience, but not so much as the whole connection dropping, which is what this pull requests aims to address.

In the end, the question is how much effort is it worth making this part of the site behaving perfectly, vs making it robust.

On Sat, Nov 23, 2013 at 1:57 PM, Gerald de Jong notifications@github.comwrote:

Ok then comet sucks too, unless there's something surmountable keeping us from enjoying the pleasures of websockets.

— Reply to this email directly or view it on GitHubhttps://github.com/delving/culture-hub/pull/941#issuecomment-29131919 .

geralddejong commented 10 years ago

I guess if Linux is the only case where it looks funny, we should not be worried.