delving / sip-creator

The Delving SIP-Creator
sip-creator.delving.eu
9 stars 3 forks source link

sip-creator reports false notification for upgrade #483

Closed hanswesterbeek closed 7 years ago

hanswesterbeek commented 7 years ago

See screenshot below.

screen shot 2016-11-03 at 11 19 32 am

hanswesterbeek commented 7 years ago

The message is misleading. Sip-creator compares its own-version against the version with which the sip-zips have been created.

So, this implementation looks like a half-attempt at managing version-compatibility. It is not clear to me what the desired behavior should be.

I think the Sip-Creator must support older sip-zips up to a certain version. So, a policy must be defined for this.

That is outside the scope of this issue. I am removing the code that gives the warning message.

hanswesterbeek commented 7 years ago

Removed the code that flashes the notification.