delvr / Farseek

A Scala API for Minecraft mods.
https://minecraft.curseforge.com/projects/farseek
20 stars 5 forks source link

Crash on latest spongeforge #43

Closed Tencao closed 5 years ago

Tencao commented 6 years ago

Original issue with all relevant information - https://github.com/SpongePowered/SpongeForge/issues/2331

Tencao commented 6 years ago

Any update on a fix for this issue?

delvr commented 6 years ago

Hey Tencao, sorry for the delay on this one.

I assumed that the crash was due to Sponge changing the name of an internal method Farseek was using (as described in the linked Sponge issue), but I can't find any record in the Sponge source of that name actually changing. In fact, I was unable to reproduce the crash using the version of Sponge you were using. I tried adding Biomes'O'Plenty since it shows up in your stacktrace - still no crash.

Could you try again with only SpongeForge and Farseek/Streams/Repose and maybe BOP, and tell me if it still crashes? If not, we'll have to work to isolate the mod that triggers this.

Tencao commented 6 years ago

I'll try again later today and report back any findings

Rautherdir commented 6 years ago

While looking into this issue myself, I found that this is most likely a duplicate of https://github.com/Ordinastie/MalisisCore/issues/151 Adding MalisisCore to the list of mods mentioned above causes this issue to appear.

delvr commented 5 years ago

Thanks @Rautherdir for the update! I tested and confirmed that the crash only happens when MalisisCore is present. I'll close this issue; if the MalisisCore devs fix the issue on their end and then Farseek still crashes with their new version we'll re-open this.