PG85
commented
4 years ago - Looks like there's another dependency on com.pg85.otg.forge.ForgeWorld elsewhere in the code. Will move ForgeWorld back into the com.pg85.otg.forge package for 1.12 to preserve compatibility. ForgeWorld will be moved to com.pg85.otg.forge.world for 1.13 though.
Hey there, OTG dev here. I got a crash report for a dev version of OTG saying that streams is missing OTG classes (See: https://gist.github.com/PG85/79f9aceae660ff60ce6de8ea4fc6945f). In the past months I've done a huge refactoring of the project, so many things have been renamed and/or moved. I can see that in https://github.com/delvr/Farseek/blob/1.12/src/main/scala/farseek/world/gen/OtgHook.scala, you're injecting some code to make OTG fire the ReplaceBiomeBlocks event. For OTG 1.12.2 v8, this has been fixed and OTG fires the event itself.
Firstly, thanks for writing code specifically to support OTG. Secondly, sorry if OTG is not an model citizen in the modding eco-system and has made life hard for some other mods. For OTG 1.12.2 v8 (release within a few weeks), the project has been refactored and many issues have been solved. Hopefully, OTG will be easier to work with going forward. For now, I'll add dummy methods and classes to make sure Streams doesn't crash due to OTGHook.scala, and injects only into unused OTG code.
When OTG v8 is released, feel free to remove OTGHook.scala (although it shouldn't cause problems). For 1.13/1.14 (currently in development) I will remove backwards compatiblity for this, so I hope you don't mind updating for that when the time comes.
Thanks and cheers.