delvr / Streams

Flowing rivers in Minecraft.
https://minecraft.curseforge.com/projects/streams
55 stars 7 forks source link

Update for 1.20.x? #120

Open exocyt0sis opened 10 months ago

exocyt0sis commented 10 months ago

To my understanding, there isn't a single mod out there that adds flowing rivers to Minecraft other than "Streams". Unfortunately, it's been outdated for years. On the flip side, it's open source.

All of this being said, would it be doable to re-build the most recent release for Minecraft 1.20.x?

JJBLT commented 3 months ago

Here here! In 2024!

exocyt0sis commented 3 months ago

The most recent version (1.12-0.4.9) seems to be well over three years old, released in November 2020.

Orionox commented 2 months ago

checking in from 2024. Maybe we should get a bounty or pot going for anyone that attempts to get this working in 1.20+

exocyt0sis commented 2 months ago

checking in from 2024. Maybe we should get a bounty or pot going for anyone that attempts to get this working in 1.20+

That's a great idea! What bounty platform do you have in mind, and what target goals should the bounty payout require?

Orionox commented 2 months ago

checking in from 2024. Maybe we should get a bounty or pot going for anyone that attempts to get this working in 1.20+

That's a great idea! What bounty platform do you have in mind, and what target goals should the bounty payout require?

no idea, i just know other modding scenes have a bounty scene. I'm not super familiar with mc's though.

delvr commented 1 month ago

Hi @exocyt0sis @Orionox & @JJBLT, sorry for the very long pause on this mod, I was in a bad spot for a while. But I've recently resumed work on Streams and will be posting a quick progress video on my YouTube channel this week.

I'm also planning to re-open-source the Streams code soon; it's a complete re-write and will be in a new repo but I'll link it from here once it's ready. I'm also planning to port the new code (currently stuck in 1.16.5) to the latest MC version around the same time.

Anyone who wants to help in development is very welcome to do so, though I suggest waiting for the new repo instead of starting from the old 1.12 codebase. Thanks for your patience and stay tuned for new updates!

-d.

exocyt0sis commented 1 month ago

Hi @exocyt0sis @Orionox & @JJBLT, sorry for the very long pause on this mod, I was in a bad spot for a while. But I've recently resumed work on Streams and will be posting a quick progress video on my YouTube channel this week.

I'm also planning to re-open-source the Streams code soon; it's a complete re-write and will be in a new repo but I'll link it from here once it's ready. I'm also planning to port the new code (currently stuck in 1.16.5) to the latest MC version around the same time.

Anyone who wants to help in development is very welcome to do so, though I suggest waiting for the new repo instead of starting from the old 1.12 codebase. Thanks for your patience and stay tuned for new updates!

-d.

Hi, and thanks for the update - all of what you're saying sounds really exciting. I've really enjoyed your work in the past, so I'm glad to hear that you seem to have found the path forwards, so to speak. Crossing my fingers that you've also regained the enjoyment for software development! Regarding helping out, I suspect that Streams is likely an exercise in recursions and object oriented programmering. Unfortunately, I only "speak" plain old C so what you are doing is beyond my skillset by a wide margin. However - if I can pitch in by reporting a bug or two at the new repository, I'm glad to help out.

Also, I'd be more than happy to get in touch with a few of the YouTube channels that cover Minecraft mods, if that's something you'd like. Like I think everyone in this thread is well aware of, the (social) media landscape has completely transformed since Streams was originally released. With a few targeted "press releases", I'm confident that the updated versions can gain traction in a way previous versions were nowhere near - and ultimately, that Streams can get the userbase it truely deserves!

Keep those waterfalls running, d! 👍

delvr commented 1 month ago

Thanks @exocyt0sis for the praise! The new demo video is up!

As for getting the mod more exposure - I've been thinking about that, actually, while recording that barebones video without any narrative or captions or transitions. :-D I haven't really done modern content production and promotion before, so perhaps I could use some help in the near future, as we get closer to an actual release.

Goosegit11 commented 3 weeks ago

That's very, very cool. Thanks for continuing the mod!

What about old versions, like 1.7.10 and 1.12.2? Do you plan on updating/supporting them?

delvr commented 3 weeks ago

That's very, very cool. Thanks for continuing the mod!

What about old versions, like 1.7.10 and 1.12.2? Do you plan on updating/supporting them?

Thanks @Goosegit11 ! Right now I'm focused on porting the mod to the latest version (1.21) and won't be able to update older versions, especially since the new mod is a complete rewrite. Perhaps an enterprising developer could make updates to the old codebase, but it would be quite a large task.

exocyt0sis commented 2 weeks ago

@delvr

I hope that the development is coming along nicely and in a progress that reasons resonable. Speaking from my own experience, not feeling any pressure from anyone when writing code usually paves the way for fun projects. "It'll take whatever time it needs", so to speak.

Meanwhile, here are a few questions if you don't mind?

  1. Will the new waterblocks feature some kind of "current stength attribute" or "flow speed attribute", so that other mods (like Create or Mekanism) can implement hydro electric power generation? A fast moving creek might be ideal for early gameplay, while a slow moving but wide river may prove to be an upgrade at a later time.

  2. Will Streams for 1.21 and beyond be "generalized" in the way that it'll implement flowing liquids in general, or will it "just" target water?

  3. Finally, as you likely already know the team behind the once popular world generation mod TerraForged are dusting off the code. The plan is to re-launch the mod for, as I understand it, 1.20 and above, under the name "ReTerraForged". Their Discord mentions that their worlds will feature rivers with varying heights. With this in mind, how "mod interoperable / mod agnostic" till Streams for 1.21+ be? Will there, by any chance, be "hooks" that other mod developers can latch onto, allowing running water from Streams to flow across worlds generated by mods such as ReTerraForged?

delvr commented 2 weeks ago

Hey @exocyt0sis thanks again for your support! I've got some answers to your questions:

  1. There is indeed a flow speed attribute with 3 levels: the vanilla speed, slower, and slowest. Currently I use the vanilla/fastest speed in tributaries and in the bulk of the main rivers, and the slower speed in the shallow portions of main rivers near the shore. Unfortunately this behavior isn't really visible in the latest video I posted, because most of it is in a cold biome, and the slower currents are configured to freeze over when appropriate (the fast currents never do). But you might see the slower currents in the previous video (with the jungle) if you look closely.

  2. The new Streams is "generalized" in the sense that the flow direction and speed are actually attributes of the air block immediately above the fluid surface. This may sound weird, but it's actually a huge improvement over the old Streams where I used custom liquid blocks and had to patch the code all over to get them treated as normal liquids by the game. With this system, I only need to patch the flow-vector code, and the blocks otherwise behave like normal fluids of their type.

  3. I'm always excited to hear about other mods' implementations of flowing and/or variable-height rivers, and I'm curious to see how they'll do it. But in any case, mod compatibility is hard to predict before both my and their mods are released, and we can see how they interact. Some mods might work straight away, others will require some patching. But unfortunately, one thing is almost certain: for technical reasons Streams by itself will never be able to convert existing rivers (whether vanilla or modded) to have a current; it can only generate its own rivers with built-in currents. That said, if you go back to the first sneak-peak video I posted (the one with the buckets) I showed that there will be enchantments allowing players to place or convert individual water blocks to give them a current depending on which way the player is facing (kind of like when placing standing signs etc), so an enterprising individual could assign currents to a static river given lots of patience. :)

JJBLT commented 2 weeks ago

Well hey. Thanks for writing us back, we more than appreciate it I'm sure, if I can speak for all of us here.

Going through hard times is a just a part of life and while it may mean taking breaks from things you enjoy doing like modding our favourite game, then SO BE IT. Mental and physical health take top priority. I certainly hope you and yours are doing better, regardless of the reason. And I am looking forward to hearing more from you and the others here.

More than anything, thanks for writing us back and taking the time to bring this mod up to speed.

Thanks a million, JJBLT <3