delvtech / agent0

Analysis & simulation repo for Delv
https://agent0.readthedocs.io/en/latest/
Apache License 2.0
49 stars 21 forks source link

Normalizing test delta in lp share price check #1438

Closed slundqui closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.71%. Comparing base (d1a465e) to head (321d19b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1438 +/- ## ========================================== + Coverage 80.70% 80.71% +0.01% ========================================== Files 104 104 Lines 6452 6452 ========================================== + Hits 5207 5208 +1 + Misses 1245 1244 -1 ``` | [Flag](https://app.codecov.io/gh/delvtech/agent0/pull/1438/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/delvtech/agent0/pull/1438/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | `80.71% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dpaiton commented 4 months ago

I think the math makes sense but it is more intuitive to me to normalize the expected value than the tolerance. what do you think?