codecov[bot]
commented
3 months ago Codecov Report
Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.
Project coverage is 80.58%. Comparing base (
fd94870) to head (1559e2d).
| Files | Patch % | Lines |
|---|---|---|
| src/agent0/core/hyperdrive/interactive/chain.py | 44.44% | 5 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1451 +/- ## ========================================== - Coverage 80.74% 80.58% -0.16% ========================================== Files 104 104 Lines 6450 6450 ========================================== - Hits 5208 5198 -10 - Misses 1242 1252 +10 ``` | [Flag](https://app.codecov.io/gh/delvtech/agent0/pull/1451/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/delvtech/agent0/pull/1451/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | `80.58% <44.44%> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The duplicate addresses check exists as guardrails to prevent the underlying wallet object from getting out of sync. This unnecessarily prevents e.g., having one wallet interact with multiple pools. While we haven't fixed the underlying issue (i.e., multiple agent objects has one underlying wallet on chain can make wallet objects go out of sync), this guardrail is too restrictive to keep, and instead we depend on communication about syncing the wallet to solve this issue.
Other minor formatting and fixes.