Closed slundqui closed 5 months ago
Attention: Patch coverage is 78.57143%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 81.27%. Comparing base (
fc53b4f
) to head (98baf4c
).:exclamation: Current head 98baf4c differs from pull request most recent head 34d586f. Consider uploading reports for the commit 34d586f to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR cleans up various unnecessary configs, enabled by making the old workflow obsolete.
EthConfig
object in favor of passing in anrpc_uri
andhyperdrive_address
for the interface.hyperdrive_address
to a specific pool.preview_before_trade
up the call chain to avoid setting it inEthConfig
.redeem_withdraw_shares
preview call inpreview_before_trade
.