codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
Project coverage is 80.50%. Comparing base (
e7e2c22) to head (5f83498).
| Files | Patch % | Lines |
|---|---|---|
| ...gent0/ethpy/hyperdrive/interface/read_interface.py | 75.00% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1513 +/- ## ========================================== - Coverage 81.14% 80.50% -0.65% ========================================== Files 97 97 Lines 6948 6954 +6 ========================================== - Hits 5638 5598 -40 - Misses 1310 1356 +46 ``` | [Flag](https://app.codecov.io/gh/delvtech/agent0/pull/1513/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/delvtech/agent0/pull/1513/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | `80.50% <87.50%> (-0.65%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think we should make a pool (or chain?) config variable that sets the default of
bytes.fromhex("a0")for the extra data. Then a user can override to empty if they don't want it.