delvtech / agent0

Analysis & simulation repo for Delv
https://agent0.readthedocs.io/en/latest/
Apache License 2.0
52 stars 21 forks source link

Redeem withdrawal shares not subject to min tx amount #1546

Closed slundqui closed 4 months ago

slundqui commented 4 months ago

This fixes a bug with random bots trying to withdraw the minimum transaction amount when this amount > withdrawal shares in wallet.

Hyperdrive does not restrict redeeming withdrawal shares to the minimum transaction amount

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.91%. Comparing base (ed9fe41) to head (d4a7b09).

:exclamation: Current head d4a7b09 differs from pull request most recent head fb89840

Please upload reports for the commit fb89840 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1546 +/- ## ========================================== - Coverage 81.14% 80.91% -0.23% ========================================== Files 98 98 Lines 7044 7044 ========================================== - Hits 5716 5700 -16 - Misses 1328 1344 +16 ``` | [Flag](https://app.codecov.io/gh/delvtech/agent0/pull/1546/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/delvtech/agent0/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech) | `80.91% <100.00%> (-0.23%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=delvtech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.