search

delvtech / council

Flexible DAO governance smart contracts, developed by Delv.
Apache License 2.0
93 stars 19 forks source link

`DAY_IN_BLOCKS` post-merge #51

Closed jrhea closed 2 years ago

jrhea commented 2 years ago

How important is it that DAY_IN_BLOCKSmatches actual block time? Keep in mind that block times will be 12 seconds post merge:

https://github.com/element-fi/council/blob/d371ac82184fc26e19e958bd0b861f83e74b2955/contracts/CoreVoting.sol#L15

aleph-v commented 2 years ago

It's not important since the values can be changed, DAY_IN_BLOCKS is just for code cleanliness and convenience.