delvtech / council

Flexible DAO governance smart contracts, developed by Delv.

Apache License 2.0

93 stars 19 forks source link

Hash on chain in the Timlock #82

Open ryangoree opened 1 year ago

ryangoree commented 1 year ago

This would make it possible to see what actions have been registered.

It would also make it possible to see what actions are being proposed in CoreVoting. When the actions are hashed off chain, we can only see a callHash for Timelock proposals.

83

github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 4775851501

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 94.207%

Totals
Change from base Build 4347624322:	0.02%
Covered Lines:	514
Relevant Lines:	531

💛 - Coveralls

sentilesdal commented 6 months ago

Closing for now since this is stale. We can open another PR if we want this feature later.

ryangoree commented 6 months ago

Re-opening for increased visibility and consideration.

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8742545879

Details

3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 94.093%

Totals
Change from base Build 8742493929:	-0.1%
Covered Lines:	515
Relevant Lines:	532