Closed sentilesdal closed 2 months ago
Benchmark suite | Current: 24c06d085e6cde096e1196a64048141c1e59356e | Previous: daa84ff9d3859c973c20c668f2ca19e2836c2c0c | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33893 gas |
33893 gas |
0% |
π° |
addLiquidity: avg |
145057 gas |
145691 gas |
-0.4352% |
β |
addLiquidity: max |
428335 gas |
428319 gas |
0.0037% |
π¨ |
checkpoint: min |
40220 gas |
40220 gas |
0% |
π° |
checkpoint: avg |
104466 gas |
104390 gas |
0.0728% |
π¨ |
checkpoint: max |
212154 gas |
212154 gas |
0% |
π° |
closeLong: min |
31517 gas |
31517 gas |
0% |
π° |
closeLong: avg |
138613 gas |
138800 gas |
-0.1347% |
β |
closeLong: max |
2640435 gas |
2640435 gas |
0% |
π° |
closeShort: min |
31394 gas |
31394 gas |
0% |
π° |
closeShort: avg |
133220 gas |
133049 gas |
0.1285% |
π¨ |
closeShort: max |
227565 gas |
227565 gas |
0% |
π° |
initialize: min |
31305 gas |
31305 gas |
0% |
π° |
initialize: avg |
253643 gas |
253642 gas |
0.0004% |
π¨ |
initialize: max |
322898 gas |
322898 gas |
0% |
π° |
openLong: min |
33437 gas |
33437 gas |
0% |
π° |
openLong: avg |
167196 gas |
167314 gas |
-0.0705% |
β |
openLong: max |
253057 gas |
253057 gas |
0% |
π° |
openShort: min |
33959 gas |
33959 gas |
0% |
π° |
openShort: avg |
170200 gas |
170230 gas |
-0.0176% |
β |
openShort: max |
385545 gas |
385545 gas |
0% |
π° |
redeemWithdrawalShares: min |
31227 gas |
31227 gas |
0% |
π° |
redeemWithdrawalShares: avg |
62864 gas |
62768 gas |
0.1529% |
π¨ |
redeemWithdrawalShares: max |
167572 gas |
167572 gas |
0% |
π° |
removeLiquidity: min |
31191 gas |
31191 gas |
0% |
π° |
removeLiquidity: avg |
222030 gas |
221627 gas |
0.1818% |
π¨ |
removeLiquidity: max |
398887 gas |
398863 gas |
0.0060% |
π¨ |
This comment was automatically generated by workflow using github-action-benchmark.
Description
Adds helper methods that we can test. Adding in it's own PR here since the rust code will now live in hyperdrive-rs and this needs to land first.
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?