Remove `HyperdriveTarget4` and `HyperdriveTarget5`

[jalextowle]

Description

This PR removes HyperdriveTarget4 and HyperdriveTarget5 since those targets were no longer needed after making LPMath an external library. In addition to removing these targets, the PR also adds getNumberOfTargets() to the IHyperdriveDeployerCoordinator interface so that it is easy to figure out how many times to call deployTarget when deploying new instances through the factory.

Review Checklists

Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled ## [Reviewer Name]. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.

@jrhea

• [ ] Tokens
  • [ ] Do all approve calls use forceApprove?
  • [ ] Do all transfer calls use safeTransfer?
  • [ ] Do all transferFrom calls use msg.sender as the from address?
    • [ ] If not, is the function access restricted to prevent unauthorized token spend?
• [ ] Low-level calls (call, delegatecall, staticcall, transfer, send)
  • [ ] Is the returned success boolean checked to handle failed calls?
  • [ ] If using delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible to delegatecall arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.
• [ ] Reentrancy
  • [ ] Are functions that make external calls or transfer ether marked as nonReentrant?
    • [ ] If not, is there documentation that explains why reentrancy is not a concern or how it's mitigated?
• [ ] Gas Optimizations
  • [ ] Is the logic as simple as possible?
  • [ ] Are the storage values that are used repeatedly cached in stack or memory variables?
  • [ ] If loops are used, are there guards in place to avoid out-of-gas issues?
• [ ] Visibility
  • [ ] Are all payable functions restricted to avoid stuck ether?
• [ ] Math
  • [ ] Is all of the arithmetic checked or guarded by if-statements that will catch underflows?
  • [ ] If Safe functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?
  • [ ] Are all of the rounding directions clearly documented?
• [ ] Testing
  • [ ] Are there new or updated unit or integration tests?
  • [ ] Do the tests cover the happy paths?
  • [ ] Do the tests cover the unhappy paths?
  • [ ] Are there an adequate number of fuzz tests to ensure that we are covering the full input space?

@mcclurejt

• [x] Tokens
  • [ ] Do all approve calls use forceApprove?
  • [ ] Do all transfer calls use safeTransfer?
  • [ ] Do all transferFrom calls use msg.sender as the from address?
    • [ ] If not, is the function access restricted to prevent unauthorized token spend?
• [x] Low-level calls (call, delegatecall, staticcall, transfer, send)
  • [ ] Is the returned success boolean checked to handle failed calls?
  • [ ] If using delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible to delegatecall arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.
• [ ] Reentrancy
  • [ ] Are functions that make external calls or transfer ether marked as nonReentrant?
    • [ ] If not, is there documentation that explains why reentrancy is not a concern or how it's mitigated?
• [ ] Gas Optimizations
  • [ ] Is the logic as simple as possible?
  • [ ] Are the storage values that are used repeatedly cached in stack or memory variables?
  • [ ] If loops are used, are there guards in place to avoid out-of-gas issues?
• [ ] Visibility
  • [ ] Are all payable functions restricted to avoid stuck ether?
• [ ] Math
  • [ ] Is all of the arithmetic checked or guarded by if-statements that will catch underflows?
  • [ ] If Safe functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?
  • [ ] Are all of the rounding directions clearly documented?
• [ ] Testing
  • [ ] Are there new or updated unit or integration tests?
  • [ ] Do the tests cover the happy paths?
  • [ ] Do the tests cover the unhappy paths?
  • [ ] Are there an adequate number of fuzz tests to ensure that we are covering the full input space?

[coveralls]

Pull Request Test Coverage Report for Build 8931268969

Details

• 21 of 21 (100.0%) changed or added relevant lines in 5 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.08%) to 93.235%

---

Files with Coverage Reduction	New Missed Lines	%
contracts/src/factory/HyperdriveFactory.sol	1	99.16%
<!--	Total:	1		-->

Totals
Change from base Build 8929108966:	0.08%
Covered Lines:	1833
Relevant Lines:	1966

---

💛 - Coveralls

[github-actions[bot]]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 167ead6665ae05b42918054317d8a931b2f585d5	Previous: 1389e3b571fc11c5acfe5adb323a4e41cfedba35	Deviation	Status
addLiquidity: min	33827 gas	33893 gas	-0.1947%	✅
addLiquidity: avg	155982 gas	148557 gas	4.9981%	🚨
addLiquidity: max	428439 gas	416093 gas	2.9671%	🚨
checkpoint: min	40270 gas	40220 gas	0.1243%	🚨
checkpoint: avg	142260 gas	104465 gas	36.1796%	🚨
checkpoint: max	253402 gas	211582 gas	19.7654%	🚨
closeLong: min	31361 gas	31517 gas	-0.4950%	✅
closeLong: avg	135140 gas	136932 gas	-1.3087%	✅
closeLong: max	2625774 gas	2640435 gas	-0.5552%	✅
closeShort: min	31349 gas	31394 gas	-0.1433%	✅
closeShort: avg	131602 gas	133435 gas	-1.3737%	✅
closeShort: max	262932 gas	253640 gas	3.6635%	🚨
initialize: min	31371 gas	31265 gas	0.3390%	🚨
initialize: avg	330389 gas	276137 gas	19.6468%	🚨
initialize: max	396281 gas	344216 gas	15.1257%	🚨
openLong: min	33370 gas	33348 gas	0.0660%	🚨
openLong: avg	173394 gas	166642 gas	4.0518%	🚨
openLong: max	306679 gas	253064 gas	21.1863%	🚨
openShort: min	33936 gas	33959 gas	-0.0677%	✅
openShort: avg	167907 gas	162950 gas	3.0420%	🚨
openShort: max	415363 gas	406806 gas	2.1035%	🚨
redeemWithdrawalShares: min	31251 gas	31251 gas	0%	🟰
redeemWithdrawalShares: avg	74482 gas	73122 gas	1.8599%	🚨
redeemWithdrawalShares: max	209762 gas	204973 gas	2.3364%	🚨
removeLiquidity: min	31301 gas	31191 gas	0.3527%	🚨
removeLiquidity: avg	208999 gas	198301 gas	5.3948%	🚨
removeLiquidity: max	403574 gas	395673 gas	1.9969%	🚨

This comment was automatically generated by workflow using github-action-benchmark.