Fixed the `MockERC4626` vault

[jalextowle]

Description

This PR makes the maxMintAmount mutable and adds an unrestricted flow for minting. This will fix the problems that we've seen on testnet with the sDAI vault.

Review Checklists

Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled ## [Reviewer Name]. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.

[[Reviewer Name]]

• [ ] Tokens
  • [ ] Do all approve calls use forceApprove?
  • [ ] Do all transfer calls use safeTransfer?
  • [ ] Do all transferFrom calls use msg.sender as the from address?
    • [ ] If not, is the function access restricted to prevent unauthorized token spend?
• [ ] Low-level calls (call, delegatecall, staticcall, transfer, send)
  • [ ] Is the returned success boolean checked to handle failed calls?
  • [ ] If using delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible to delegatecall arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.
• [ ] Reentrancy
  • [ ] Are functions that make external calls or transfer ether marked as nonReentrant?
    • [ ] If not, is there documentation that explains why reentrancy is not a concern or how it's mitigated?
• [ ] Gas Optimizations
  • [ ] Is the logic as simple as possible?
  • [ ] Are the storage values that are used repeatedly cached in stack or memory variables?
  • [ ] If loops are used, are there guards in place to avoid out-of-gas issues?
• [ ] Visibility
  • [ ] Are all payable functions restricted to avoid stuck ether?
• [ ] Math
  • [ ] Is all of the arithmetic checked or guarded by if-statements that will catch underflows?
  • [ ] If Safe functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?
  • [ ] Are all of the rounding directions clearly documented?
• [ ] Testing
  • [ ] Are there new or updated unit or integration tests?
  • [ ] Do the tests cover the happy paths?
  • [ ] Do the tests cover the unhappy paths?
  • [ ] Are there an adequate number of fuzz tests to ensure that we are covering the full input space?

[coveralls]

Pull Request Test Coverage Report for Build 8944755568

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.235%

---

Totals
Change from base Build 8933353219:	0.0%
Covered Lines:	1833
Relevant Lines:	1966

---

💛 - Coveralls

[github-actions[bot]]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 8545bb75382a731aa463549fc99f61e9124c184f	Previous: fee327731672c92ce71cc350a996016a30c5a617	Deviation	Status
addLiquidity: min	33827 gas	33827 gas	0%	🟰
addLiquidity: avg	155879 gas	156220 gas	-0.2183%	✅
addLiquidity: max	428439 gas	428439 gas	0%	🟰
checkpoint: min	40270 gas	40270 gas	0%	🟰
checkpoint: avg	142302 gas	142275 gas	0.0190%	🚨
checkpoint: max	253402 gas	253402 gas	0%	🟰
closeLong: min	31361 gas	31361 gas	0%	🟰
closeLong: avg	135168 gas	135375 gas	-0.1529%	✅
closeLong: max	2625774 gas	2625774 gas	0%	🟰
closeShort: min	31349 gas	31349 gas	0%	🟰
closeShort: avg	131549 gas	131559 gas	-0.0076%	✅
closeShort: max	262932 gas	401793 gas	-34.5603%	✅
initialize: min	31371 gas	31371 gas	0%	🟰
initialize: avg	330371 gas	330281 gas	0.0272%	🚨
initialize: max	396281 gas	396281 gas	0%	🟰
openLong: min	33370 gas	33370 gas	0%	🟰
openLong: avg	173306 gas	173566 gas	-0.1498%	✅
openLong: max	306679 gas	306679 gas	0%	🟰
openShort: min	33936 gas	33936 gas	0%	🟰
openShort: avg	168018 gas	167896 gas	0.0727%	🚨
openShort: max	415379 gas	414945 gas	0.1046%	🚨
redeemWithdrawalShares: min	31251 gas	31251 gas	0%	🟰
redeemWithdrawalShares: avg	74660 gas	74650 gas	0.0134%	🚨
redeemWithdrawalShares: max	209762 gas	209762 gas	0%	🟰
removeLiquidity: min	31301 gas	31301 gas	0%	🟰
removeLiquidity: avg	208895 gas	208656 gas	0.1145%	🚨
removeLiquidity: max	403397 gas	403574 gas	-0.0439%	✅

This comment was automatically generated by workflow using github-action-benchmark.