Closed jalextowle closed 2 months ago
Totals | |
---|---|
Change from base Build 8945345065: | 0.0% |
Covered Lines: | 1833 |
Relevant Lines: | 1966 |
Benchmark suite | Current: 664b3fe62f62e0dddd8f6e7f49de6dd5035e27f0 | Previous: a74a586f2b417d8253102adc32cfbb38ed7807d0 | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33827 gas |
33827 gas |
0% |
🟰 |
addLiquidity: avg |
156773 gas |
156478 gas |
0.1885% |
🚨 |
addLiquidity: max |
428439 gas |
428439 gas |
0% |
🟰 |
checkpoint: min |
40270 gas |
40270 gas |
0% |
🟰 |
checkpoint: avg |
142253 gas |
142320 gas |
-0.0471% |
✅ |
checkpoint: max |
253402 gas |
253402 gas |
0% |
🟰 |
closeLong: min |
31361 gas |
31361 gas |
0% |
🟰 |
closeLong: avg |
135387 gas |
135287 gas |
0.0739% |
🚨 |
closeLong: max |
2625774 gas |
2625774 gas |
0% |
🟰 |
closeShort: min |
31349 gas |
31349 gas |
0% |
🟰 |
closeShort: avg |
131675 gas |
131622 gas |
0.0403% |
🚨 |
closeShort: max |
262932 gas |
262932 gas |
0% |
🟰 |
initialize: min |
31371 gas |
31371 gas |
0% |
🟰 |
initialize: avg |
330250 gas |
330317 gas |
-0.0203% |
✅ |
initialize: max |
396281 gas |
396281 gas |
0% |
🟰 |
openLong: min |
33370 gas |
33370 gas |
0% |
🟰 |
openLong: avg |
173420 gas |
173342 gas |
0.0450% |
🚨 |
openLong: max |
306679 gas |
306679 gas |
0% |
🟰 |
openShort: min |
33936 gas |
33936 gas |
0% |
🟰 |
openShort: avg |
168079 gas |
167949 gas |
0.0774% |
🚨 |
openShort: max |
414945 gas |
412493 gas |
0.5944% |
🚨 |
redeemWithdrawalShares: min |
31251 gas |
31251 gas |
0% |
🟰 |
redeemWithdrawalShares: avg |
74861 gas |
74747 gas |
0.1525% |
🚨 |
redeemWithdrawalShares: max |
209762 gas |
209762 gas |
0% |
🟰 |
removeLiquidity: min |
31301 gas |
31301 gas |
0% |
🟰 |
removeLiquidity: avg |
208737 gas |
209212 gas |
-0.2270% |
✅ |
removeLiquidity: max |
403586 gas |
403586 gas |
0% |
🟰 |
This comment was automatically generated by workflow using github-action-benchmark.
Description
Rename
deploy
to eitherdeployHyperdrive
ordeployTarget
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?