Closed jalextowle closed 4 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
contracts/src/libraries/LPMath.sol | 1 | 84.29% | ||
<!-- | Total: | 1 | --> |
Totals | |
---|---|
Change from base Build 9068100899: | -0.08% |
Covered Lines: | 1833 |
Relevant Lines: | 1963 |
Benchmark suite | Current: 9004b812e3b04fcbb425479af47ba5bbc6b79c51 | Previous: 229ee73c392a3c17e2195c9a787376b1bb205e98 | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33827 gas |
33827 gas |
0% |
🟰 |
addLiquidity: avg |
156030 gas |
156142 gas |
-0.0717% |
✅ |
addLiquidity: max |
428173 gas |
428417 gas |
-0.0570% |
✅ |
checkpoint: min |
40292 gas |
40292 gas |
0% |
🟰 |
checkpoint: avg |
142293 gas |
142230 gas |
0.0443% |
🚨 |
checkpoint: max |
253424 gas |
253424 gas |
0% |
🟰 |
closeLong: min |
31361 gas |
31361 gas |
0% |
🟰 |
closeLong: avg |
134552 gas |
135226 gas |
-0.4984% |
✅ |
closeLong: max |
2625796 gas |
2625796 gas |
0% |
🟰 |
closeShort: min |
31349 gas |
31349 gas |
0% |
🟰 |
closeShort: avg |
130950 gas |
131666 gas |
-0.5438% |
✅ |
closeShort: max |
259737 gas |
262998 gas |
-1.2399% |
✅ |
initialize: min |
31371 gas |
31371 gas |
0% |
🟰 |
initialize: avg |
330037 gas |
330297 gas |
-0.0787% |
✅ |
initialize: max |
396015 gas |
396259 gas |
-0.0616% |
✅ |
openLong: min |
33370 gas |
33370 gas |
0% |
🟰 |
openLong: avg |
172509 gas |
173493 gas |
-0.5672% |
✅ |
openLong: max |
306039 gas |
306657 gas |
-0.2015% |
✅ |
openShort: min |
33936 gas |
33936 gas |
0% |
🟰 |
openShort: avg |
167474 gas |
168000 gas |
-0.3131% |
✅ |
openShort: max |
414992 gas |
415283 gas |
-0.0701% |
✅ |
redeemWithdrawalShares: min |
31251 gas |
31251 gas |
0% |
🟰 |
redeemWithdrawalShares: avg |
74213 gas |
74856 gas |
-0.8590% |
✅ |
redeemWithdrawalShares: max |
209214 gas |
209828 gas |
-0.2926% |
✅ |
removeLiquidity: min |
31301 gas |
31301 gas |
0% |
🟰 |
removeLiquidity: avg |
207980 gas |
208856 gas |
-0.4194% |
✅ |
removeLiquidity: max |
403038 gas |
403640 gas |
-0.1491% |
✅ |
This comment was automatically generated by workflow using github-action-benchmark.
Description
Updated the event schema so that it is more feasible to recreate the state using events.
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?