Closed jalextowle closed 2 months ago
Totals | |
---|---|
Change from base Build 9072620755: | 0.05% |
Covered Lines: | 1834 |
Relevant Lines: | 1963 |
Benchmark suite | Current: 612a53b53ffa3e6f9d3c2014478e4a698b201bc3 | Previous: 33982bba72d861b3b90cb0b4083fec30accb649f | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33827 gas |
33827 gas |
0% |
š° |
addLiquidity: avg |
156022 gas |
156187 gas |
-0.1056% |
ā |
addLiquidity: max |
428173 gas |
428173 gas |
0% |
š° |
checkpoint: min |
40292 gas |
40292 gas |
0% |
š° |
checkpoint: avg |
142247 gas |
142358 gas |
-0.0780% |
ā |
checkpoint: max |
253424 gas |
253424 gas |
0% |
š° |
closeLong: min |
31361 gas |
31361 gas |
0% |
š° |
closeLong: avg |
134727 gas |
134534 gas |
0.1435% |
šØ |
closeLong: max |
2625796 gas |
2625796 gas |
0% |
š° |
closeShort: min |
31349 gas |
31349 gas |
0% |
š° |
closeShort: avg |
131187 gas |
131111 gas |
0.0580% |
šØ |
closeShort: max |
401245 gas |
262384 gas |
52.9228% |
šØ |
initialize: min |
31371 gas |
31371 gas |
0% |
š° |
initialize: avg |
330107 gas |
330069 gas |
0.0115% |
šØ |
initialize: max |
396015 gas |
396015 gas |
0% |
š° |
openLong: min |
33370 gas |
33370 gas |
0% |
š° |
openLong: avg |
172628 gas |
172701 gas |
-0.0423% |
ā |
openLong: max |
306039 gas |
306039 gas |
0% |
š° |
openShort: min |
33936 gas |
33936 gas |
0% |
š° |
openShort: avg |
167723 gas |
167508 gas |
0.1284% |
šØ |
openShort: max |
414787 gas |
414992 gas |
-0.0494% |
ā |
redeemWithdrawalShares: min |
31251 gas |
31251 gas |
0% |
š° |
redeemWithdrawalShares: avg |
73664 gas |
73902 gas |
-0.3220% |
ā |
redeemWithdrawalShares: max |
209214 gas |
209214 gas |
0% |
š° |
removeLiquidity: min |
31301 gas |
31301 gas |
0% |
š° |
removeLiquidity: avg |
208447 gas |
208649 gas |
-0.0968% |
ā |
removeLiquidity: max |
403038 gas |
403026 gas |
0.0030% |
šØ |
This comment was automatically generated by workflow using github-action-benchmark.
Description
Renames the fields that were missed in the previous PR and adjusts the logic in
test/utils/HyperdriveUtils.sol
to avoid intermittent failures in the Rust tests.Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?