Made the registry more fully-featured

[jalextowle]

Description

Updates the schema for the registry so that it is more helpful for programmatic users. This PR also updates some inconsistencies in the HyperdriveFactory and interfaces throughout the codebase.

Review Checklists

Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled ## [Reviewer Name]. If the PR doesn't touch Solidity, the corresponding checklist can be removed.

[[Reviewer Name]]

• [ ] Tokens
  • [ ] Do all approve calls use forceApprove?
  • [ ] Do all transfer calls use safeTransfer?
  • [ ] Do all transferFrom calls use msg.sender as the from address?
    • [ ] If not, is the function access restricted to prevent unauthorized token spend?
• [ ] Low-level calls (call, delegatecall, staticcall, transfer, send)
  • [ ] Is the returned success boolean checked to handle failed calls?
  • [ ] If using delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible to delegatecall arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.
• [ ] Reentrancy
  • [ ] Are functions that make external calls or transfer ether marked as nonReentrant?
    • [ ] If not, is there documentation that explains why reentrancy is not a concern or how it's mitigated?
• [ ] Gas Optimizations
  • [ ] Is the logic as simple as possible?
  • [ ] Are the storage values that are used repeatedly cached in stack or memory variables?
  • [ ] If loops are used, are there guards in place to avoid out-of-gas issues?
• [ ] Visibility
  • [ ] Are all payable functions restricted to avoid stuck ether?
• [ ] Math
  • [ ] Is all of the arithmetic checked or guarded by if-statements that will catch underflows?
  • [ ] If Safe functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?
  • [ ] Are all of the rounding directions clearly documented?
• [ ] Testing
  • [ ] Are there new or updated unit or integration tests?
  • [ ] Do the tests cover the happy paths?
  • [ ] Do the tests cover the unhappy paths?
  • [ ] Are there an adequate number of fuzz tests to ensure that we are covering the full input space?

[coveralls]

Pull Request Test Coverage Report for Build 9374541861

Details

• 96 of 109 (88.07%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.3%) to 93.031%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contracts/src/factory/HyperdriveFactory.sol	13	17	76.47%
contracts/src/factory/HyperdriveRegistry.sol	83	92	90.22%
<!--	Total:	96	109	88.07%	-->

Files with Coverage Reduction	New Missed Lines	%
contracts/src/factory/HyperdriveRegistry.sol	1	89.36%
<!--	Total:	1		-->

Totals
Change from base Build 9334613106:	-0.3%
Covered Lines:	1909
Relevant Lines:	2052

---

💛 - Coveralls

[github-actions[bot]]

Hyperdrive Gas Benchmark

Benchmark suite	Current: dc558a619efe3a64f48290d32a3ac83bde513294	Previous: d47b4e99631301d74daf01fc47681b3ce50beac9	Deviation	Status
addLiquidity: min	33827 gas	33827 gas	0%	🟰
addLiquidity: avg	155096 gas	155515 gas	-0.2694%	✅
addLiquidity: max	429092 gas	428173 gas	0.2146%	🚨
checkpoint: min	40292 gas	40292 gas	0%	🟰
checkpoint: avg	142270 gas	142272 gas	-0.0014%	✅
checkpoint: max	253424 gas	253424 gas	0%	🟰
closeLong: min	31361 gas	31361 gas	0%	🟰
closeLong: avg	136101 gas	134707 gas	1.0348%	🚨
closeLong: max	2625796 gas	2625796 gas	0%	🟰
closeShort: min	31349 gas	31349 gas	0%	🟰
closeShort: avg	132110 gas	131060 gas	0.8012%	🚨
closeShort: max	309547 gas	262384 gas	17.9748%	🚨
initialize: min	31371 gas	31371 gas	0%	🟰
initialize: avg	331019 gas	330116 gas	0.2735%	🚨
initialize: max	397010 gas	396015 gas	0.2513%	🚨
openLong: min	33370 gas	33370 gas	0%	🟰
openLong: avg	174071 gas	172914 gas	0.6691%	🚨
openLong: max	306958 gas	306039 gas	0.3003%	🚨
openShort: min	33936 gas	33936 gas	0%	🟰
openShort: avg	168677 gas	167433 gas	0.7430%	🚨
openShort: max	415814 gas	414787 gas	0.2476%	🚨
redeemWithdrawalShares: min	31251 gas	31251 gas	0%	🟰
redeemWithdrawalShares: avg	75041 gas	74277 gas	1.0286%	🚨
redeemWithdrawalShares: max	210204 gas	209214 gas	0.4732%	🚨
removeLiquidity: min	31301 gas	31301 gas	0%	🟰
removeLiquidity: avg	214444 gas	208376 gas	2.9120%	🚨
removeLiquidity: max	403959 gas	403026 gas	0.2315%	🚨

This comment was automatically generated by workflow using github-action-benchmark.

[coveralls]

Pull Request Test Coverage Report for Build 9375326207

Details

• 96 of 109 (88.07%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.4%) to 92.982%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contracts/src/factory/HyperdriveFactory.sol	13	17	76.47%
contracts/src/factory/HyperdriveRegistry.sol	83	92	90.22%
<!--	Total:	96	109	88.07%	-->

Files with Coverage Reduction	New Missed Lines	%
contracts/src/factory/HyperdriveRegistry.sol	1	89.36%
<!--	Total:	1		-->

Totals
Change from base Build 9374786147:	-0.4%
Covered Lines:	1908
Relevant Lines:	2052

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9394935530

Details

• 96 of 109 (88.07%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.4%) to 92.982%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
contracts/src/factory/HyperdriveFactory.sol	13	17	76.47%
contracts/src/factory/HyperdriveRegistry.sol	83	92	90.22%
<!--	Total:	96	109	88.07%	-->

Files with Coverage Reduction	New Missed Lines	%
contracts/src/factory/HyperdriveRegistry.sol	1	89.36%
<!--	Total:	1		-->

Totals
Change from base Build 9392859661:	-0.4%
Covered Lines:	1908
Relevant Lines:	2052

---

💛 - Coveralls