Closed jrhea closed 4 months ago
Totals | |
---|---|
Change from base Build 9334613106: | 0.0% |
Covered Lines: | 1833 |
Relevant Lines: | 1963 |
Benchmark suite | Current: ab83d4cd3f2b90b75bbb27bd646f935187b90bf4 | Previous: d47b4e99631301d74daf01fc47681b3ce50beac9 | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33827 gas |
33827 gas |
0% |
π° |
addLiquidity: avg |
156664 gas |
155515 gas |
0.7388% |
π¨ |
addLiquidity: max |
429092 gas |
428173 gas |
0.2146% |
π¨ |
checkpoint: min |
40292 gas |
40292 gas |
0% |
π° |
checkpoint: avg |
142325 gas |
142272 gas |
0.0373% |
π¨ |
checkpoint: max |
253424 gas |
253424 gas |
0% |
π° |
closeLong: min |
31361 gas |
31361 gas |
0% |
π° |
closeLong: avg |
135542 gas |
134707 gas |
0.6199% |
π¨ |
closeLong: max |
2625796 gas |
2625796 gas |
0% |
π° |
closeShort: min |
31349 gas |
31349 gas |
0% |
π° |
closeShort: avg |
131831 gas |
131060 gas |
0.5883% |
π¨ |
closeShort: max |
263302 gas |
262384 gas |
0.3499% |
π¨ |
initialize: min |
31371 gas |
31371 gas |
0% |
π° |
initialize: avg |
331024 gas |
330116 gas |
0.2751% |
π¨ |
initialize: max |
396934 gas |
396015 gas |
0.2321% |
π¨ |
openLong: min |
33370 gas |
33370 gas |
0% |
π° |
openLong: avg |
173419 gas |
172914 gas |
0.2921% |
π¨ |
openLong: max |
306958 gas |
306039 gas |
0.3003% |
π¨ |
openShort: min |
33936 gas |
33936 gas |
0% |
π° |
openShort: avg |
168426 gas |
167433 gas |
0.5931% |
π¨ |
openShort: max |
415814 gas |
414787 gas |
0.2476% |
π¨ |
redeemWithdrawalShares: min |
31251 gas |
31251 gas |
0% |
π° |
redeemWithdrawalShares: avg |
75235 gas |
74277 gas |
1.2898% |
π¨ |
redeemWithdrawalShares: max |
210128 gas |
209214 gas |
0.4369% |
π¨ |
removeLiquidity: min |
31301 gas |
31301 gas |
0% |
π° |
removeLiquidity: avg |
209314 gas |
208376 gas |
0.4501% |
π¨ |
removeLiquidity: max |
403742 gas |
403026 gas |
0.1777% |
π¨ |
This comment was automatically generated by workflow using github-action-benchmark.
Description
The purpose of this PR is to expose the extra data to the event logs. The following functions have been updated:
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?