LP Sandwich Tests

[jalextowle]

Description

Adds testing for the LP sandwich attack to ensure that the initial LP will not lose money with a properly configured circuit breaker delta.

Review Checklists

Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled ## [Reviewer Name]. If the PR doesn't touch Solidity, the corresponding checklist can be removed.

[[Reviewer Name]]

• [ ] Tokens
  • [ ] Do all approve calls use forceApprove?
  • [ ] Do all transfer calls use safeTransfer?
  • [ ] Do all transferFrom calls use msg.sender as the from address?
    • [ ] If not, is the function access restricted to prevent unauthorized token spend?
• [ ] Low-level calls (call, delegatecall, staticcall, transfer, send)
  • [ ] Is the returned success boolean checked to handle failed calls?
  • [ ] If using delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible to delegatecall arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.
• [ ] Reentrancy
  • [ ] Are functions that make external calls or transfer ether marked as nonReentrant?
    • [ ] If not, is there documentation that explains why reentrancy is not a concern or how it's mitigated?
• [ ] Gas Optimizations
  • [ ] Is the logic as simple as possible?
  • [ ] Are the storage values that are used repeatedly cached in stack or memory variables?
  • [ ] If loops are used, are there guards in place to avoid out-of-gas issues?
• [ ] Visibility
  • [ ] Are all payable functions restricted to avoid stuck ether?
• [ ] Math
  • [ ] Is all of the arithmetic checked or guarded by if-statements that will catch underflows?
  • [ ] If Safe functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?
  • [ ] Are all of the rounding directions clearly documented?
• [ ] Testing
  • [ ] Are there new or updated unit or integration tests?
  • [ ] Do the tests cover the happy paths?
  • [ ] Do the tests cover the unhappy paths?
  • [ ] Are there an adequate number of fuzz tests to ensure that we are covering the full input space?

[coveralls]

Pull Request Test Coverage Report for Build 9375008841

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.377%

---

Totals
Change from base Build 9374786147:	0.0%
Covered Lines:	1833
Relevant Lines:	1963

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9375069920

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.377%

---

Totals
Change from base Build 9374786147:	0.0%
Covered Lines:	1833
Relevant Lines:	1963

---

💛 - Coveralls

[github-actions[bot]]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 5e6774a6f2a7d9c3dea0c2eb18daa11824f144dc	Previous: 5383ec41cfe4c92ea2831cbbd09bbab8ee94527e	Deviation	Status
addLiquidity: min	33827 gas	33827 gas	0%	🟰
addLiquidity: avg	155541 gas	156428 gas	-0.5670%	✅
addLiquidity: max	429092 gas	429092 gas	0%	🟰
checkpoint: min	40292 gas	40292 gas	0%	🟰
checkpoint: avg	142306 gas	142280 gas	0.0183%	🚨
checkpoint: max	253424 gas	253424 gas	0%	🟰
closeLong: min	31361 gas	31361 gas	0%	🟰
closeLong: avg	136118 gas	135514 gas	0.4457%	🚨
closeLong: max	2625796 gas	2625796 gas	0%	🟰
closeShort: min	31349 gas	31349 gas	0%	🟰
closeShort: avg	131995 gas	131768 gas	0.1723%	🚨
closeShort: max	263302 gas	402203 gas	-34.5350%	✅
initialize: min	31371 gas	31371 gas	0%	🟰
initialize: avg	330940 gas	331025 gas	-0.0257%	✅
initialize: max	396934 gas	396934 gas	0%	🟰
openLong: min	33370 gas	33370 gas	0%	🟰
openLong: avg	174129 gas	173464 gas	0.3834%	🚨
openLong: max	306958 gas	306958 gas	0%	🟰
openShort: min	33936 gas	33936 gas	0%	🟰
openShort: avg	168522 gas	168593 gas	-0.0421%	✅
openShort: max	415910 gas	415910 gas	0%	🟰
redeemWithdrawalShares: min	31251 gas	31251 gas	0%	🟰
redeemWithdrawalShares: avg	75021 gas	75352 gas	-0.4393%	✅
redeemWithdrawalShares: max	210128 gas	210128 gas	0%	🟰
removeLiquidity: min	31301 gas	31301 gas	0%	🟰
removeLiquidity: avg	214675 gas	209310 gas	2.5632%	🚨
removeLiquidity: max	403971 gas	403971 gas	0%	🟰

This comment was automatically generated by workflow using github-action-benchmark.

[coveralls]

Pull Request Test Coverage Report for Build 9375141576

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.377%

---

Totals
Change from base Build 9374786147:	0.0%
Covered Lines:	1833
Relevant Lines:	1963

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9392318290

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.377%

---

Totals
Change from base Build 9374786147:	0.0%
Covered Lines:	1833
Relevant Lines:	1963

---

💛 - Coveralls