coveralls
commented
1 month ago Pull Request Test Coverage Report for Build 9409026324
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 17 unchanged lines in 3 files lost coverage.
- Overall coverage increased (+0.4%) to 93.377%
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| contracts/src/internal/HyperdriveLP.sol | 4 | 96.88% | ||
| contracts/src/internal/HyperdriveLong.sol | 6 | 94.02% | ||
| contracts/src/internal/HyperdriveShort.sol | 7 | 94.17% | ||
| <!-- | Total: | 17 | --> |
| Totals | |
|---|---|
| Change from base Build 9408759390: | 0.4% |
| Covered Lines: | 1833 |
| Relevant Lines: | 1963 |
github-actions[bot]
sentilesdal
Resolved Issues
Description
This helps with testing. When solidity is called using anvil in rust tests, the block is ticked by 1 second. Because there is a call to
_getAccruedInterest()intotalAssets(), the only way to get the exact value is to pass the current time plus one second tototalAssets().Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]. If the PR doesn't touch Solidity, the corresponding checklist can be removed.[[Reviewer Name]]
approvecalls useforceApprove?transfercalls usesafeTransfer?transferFromcalls usemsg.senderas thefromaddress?call,delegatecall,staticcall,transfer,send)successboolean checked to handle failed calls?delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecallarbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant?payablefunctions restricted to avoid stuck ether?Safefunctions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?