coveralls
commented
3 months ago Pull Request Test Coverage Report for Build 9409259507
Details
- 8 of 46 (17.39%) changed or added relevant lines in 6 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-1.4%) to 91.629%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| contracts/src/factory/HyperdriveFactory.sol | 2 | 4 | 50.0% | ||
| contracts/src/internal/HyperdriveCheckpoint.sol | 4 | 6 | 66.67% | ||
| contracts/src/rewarder/HyperdriveCheckpointRewarder.sol | 0 | 11 | 0.0% | ||
| contracts/src/rewarder/ERC20HyperdriveCheckpointSubrewarder.sol | 0 | 23 | 0.0% | ||
| <!-- | Total: | 8 | 46 | 17.39% | --> |
| Totals | |
|---|---|
| Change from base Build 9408759390: | -1.4% |
| Covered Lines: | 1839 |
| Relevant Lines: | 2007 |
github-actions[bot]
Description
This PR implements a system that can be used to incentivize checkpoint rewards. This system has been intentionally designed to be flexible enough to adjust to new demands and to be able to be ignored entirely.
One interesting thing that came up while testing is that rewarding the minting of past checkpoints is potentially dangerous. This is dangerous because a minter could go back and mint all of the past checkpoints to drain the subrewarder's source address.
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]. If the PR doesn't touch Solidity, the corresponding checklist can be removed.[[Reviewer Name]]
approvecalls useforceApprove?transfercalls usesafeTransfer?transferFromcalls usemsg.senderas thefromaddress?call,delegatecall,staticcall,transfer,send)successboolean checked to handle failed calls?delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecallarbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant?payablefunctions restricted to avoid stuck ether?Safefunctions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?