Closed slundqui closed 1 month ago
Benchmark suite | Current: a145cfb703f9908e79b0efa5441c7a64f58dfec9 | Previous: b0fdad3d961f4889199a133b65a1b4d17b63b3a4 | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33827 gas |
33827 gas |
0% |
🟰 |
addLiquidity: avg |
155307 gas |
155219 gas |
0.0567% |
🚨 |
addLiquidity: max |
429092 gas |
429092 gas |
0% |
🟰 |
checkpoint: min |
40292 gas |
40292 gas |
0% |
🟰 |
checkpoint: avg |
142285 gas |
142272 gas |
0.0091% |
🚨 |
checkpoint: max |
253424 gas |
253424 gas |
0% |
🟰 |
closeLong: min |
31361 gas |
31361 gas |
0% |
🟰 |
closeLong: avg |
135955 gas |
136036 gas |
-0.0595% |
✅ |
closeLong: max |
2621386 gas |
2621386 gas |
0% |
🟰 |
closeShort: min |
31349 gas |
31349 gas |
0% |
🟰 |
closeShort: avg |
131813 gas |
132080 gas |
-0.2022% |
✅ |
closeShort: max |
263302 gas |
263302 gas |
0% |
🟰 |
initialize: min |
31371 gas |
31371 gas |
0% |
🟰 |
initialize: avg |
330985 gas |
330890 gas |
0.0287% |
🚨 |
initialize: max |
397010 gas |
397010 gas |
0% |
🟰 |
openLong: min |
33370 gas |
33370 gas |
0% |
🟰 |
openLong: avg |
173582 gas |
173827 gas |
-0.1409% |
✅ |
openLong: max |
306958 gas |
306958 gas |
0% |
🟰 |
openShort: min |
33936 gas |
33936 gas |
0% |
🟰 |
openShort: avg |
168534 gas |
168672 gas |
-0.0818% |
✅ |
openShort: max |
415910 gas |
415910 gas |
0% |
🟰 |
redeemWithdrawalShares: min |
31251 gas |
31251 gas |
0% |
🟰 |
redeemWithdrawalShares: avg |
75195 gas |
75048 gas |
0.1959% |
🚨 |
redeemWithdrawalShares: max |
210204 gas |
210204 gas |
0% |
🟰 |
removeLiquidity: min |
31301 gas |
31301 gas |
0% |
🟰 |
removeLiquidity: avg |
214103 gas |
214318 gas |
-0.1003% |
✅ |
removeLiquidity: max |
403959 gas |
403497 gas |
0.1145% |
🚨 |
This comment was automatically generated by workflow using github-action-benchmark.
Resolved Issues
Description
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?