Closed sentilesdal closed 3 weeks ago
Totals | |
---|---|
Change from base Build 9491569104: | 0.05% |
Covered Lines: | 1907 |
Relevant Lines: | 2053 |
Benchmark suite | Current: c0e8af27a813f50661e99d6de9fd3f2ae09a7a0a | Previous: f1ccfd481a50d3cc0e96ab58eea95e9e7d58183c | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33827 gas |
33827 gas |
0% |
🟰 |
addLiquidity: avg |
155569 gas |
155265 gas |
0.1958% |
🚨 |
addLiquidity: max |
429092 gas |
429092 gas |
0% |
🟰 |
checkpoint: min |
40292 gas |
40292 gas |
0% |
🟰 |
checkpoint: avg |
142306 gas |
142299 gas |
0.0049% |
🚨 |
checkpoint: max |
253424 gas |
253424 gas |
0% |
🟰 |
closeLong: min |
31361 gas |
31361 gas |
0% |
🟰 |
closeLong: avg |
135925 gas |
136051 gas |
-0.0926% |
✅ |
closeLong: max |
2621386 gas |
2621386 gas |
0% |
🟰 |
closeShort: min |
31349 gas |
31349 gas |
0% |
🟰 |
closeShort: avg |
132132 gas |
132021 gas |
0.0841% |
🚨 |
closeShort: max |
260658 gas |
355528 gas |
-26.6843% |
✅ |
initialize: min |
31371 gas |
31371 gas |
0% |
🟰 |
initialize: avg |
331013 gas |
330983 gas |
0.0091% |
🚨 |
initialize: max |
397010 gas |
397010 gas |
0% |
🟰 |
openLong: min |
33370 gas |
33370 gas |
0% |
🟰 |
openLong: avg |
173776 gas |
173792 gas |
-0.0092% |
✅ |
openLong: max |
306958 gas |
306958 gas |
0% |
🟰 |
openShort: min |
33936 gas |
33936 gas |
0% |
🟰 |
openShort: avg |
168518 gas |
168385 gas |
0.0790% |
🚨 |
openShort: max |
415702 gas |
415641 gas |
0.0147% |
🚨 |
redeemWithdrawalShares: min |
31251 gas |
31251 gas |
0% |
🟰 |
redeemWithdrawalShares: avg |
74867 gas |
74771 gas |
0.1284% |
🚨 |
redeemWithdrawalShares: max |
210204 gas |
210204 gas |
0% |
🟰 |
removeLiquidity: min |
31301 gas |
31301 gas |
0% |
🟰 |
removeLiquidity: avg |
214022 gas |
214804 gas |
-0.3641% |
✅ |
removeLiquidity: max |
403971 gas |
403971 gas |
0% |
🟰 |
This comment was automatically generated by workflow using github-action-benchmark.
Description
Bump version to 1.0.11
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?