Jalextowle/audit 06 10 2024/spearbit 10

[jalextowle]

Resolved Issues

Fixes: https://github.com/spearbit-audits/delv-week-review/issues/10

Description

Used openzeppelin's abs function. This addresses the concern from the issue without resorting to returning an invalid value.

Review Checklists

Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled ## [Reviewer Name]. If the PR doesn't touch Solidity, the corresponding checklist can be removed.

[[Reviewer Name]]

• [ ] Tokens
  • [ ] Do all approve calls use forceApprove?
  • [ ] Do all transfer calls use safeTransfer?
  • [ ] Do all transferFrom calls use msg.sender as the from address?
    • [ ] If not, is the function access restricted to prevent unauthorized token spend?
• [ ] Low-level calls (call, delegatecall, staticcall, transfer, send)
  • [ ] Is the returned success boolean checked to handle failed calls?
  • [ ] If using delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible to delegatecall arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.
• [ ] Reentrancy
  • [ ] Are functions that make external calls or transfer ether marked as nonReentrant?
    • [ ] If not, is there documentation that explains why reentrancy is not a concern or how it's mitigated?
• [ ] Gas Optimizations
  • [ ] Is the logic as simple as possible?
  • [ ] Are the storage values that are used repeatedly cached in stack or memory variables?
  • [ ] If loops are used, are there guards in place to avoid out-of-gas issues?
• [ ] Visibility
  • [ ] Are all payable functions restricted to avoid stuck ether?
• [ ] Math
  • [ ] Is all of the arithmetic checked or guarded by if-statements that will catch underflows?
  • [ ] If Safe functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?
  • [ ] Are all of the rounding directions clearly documented?
• [ ] Testing
  • [ ] Are there new or updated unit or integration tests?
  • [ ] Do the tests cover the happy paths?
  • [ ] Do the tests cover the unhappy paths?
  • [ ] Are there an adequate number of fuzz tests to ensure that we are covering the full input space?

[coveralls]

Pull Request Test Coverage Report for Build 9557569371

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.05%) to 92.139%

---

Files with Coverage Reduction	New Missed Lines	%
contracts/src/libraries/LPMath.sol	1	83.14%
<!--	Total:	1		-->

Totals
Change from base Build 9557401375:	-0.05%
Covered Lines:	1969
Relevant Lines:	2137

---

💛 - Coveralls

[github-actions[bot]]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 02d7e20548f49457dfe4d81b639937e7ad9bdf48	Previous: 41f0a714171b485d422e3dabf82ec59cae9b3994	Deviation	Status
addLiquidity: min	33937 gas	33937 gas	0%	🟰
addLiquidity: avg	155445 gas	155380 gas	0.0418%	🚨
addLiquidity: max	429244 gas	429437 gas	-0.0449%	✅
checkpoint: min	40316 gas	40316 gas	0%	🟰
checkpoint: avg	144769 gas	144623 gas	0.1010%	🚨
checkpoint: max	255931 gas	255830 gas	0.0395%	🚨
closeLong: min	31361 gas	31361 gas	0%	🟰
closeLong: avg	135955 gas	136434 gas	-0.3511%	✅
closeLong: max	2539376 gas	2621435 gas	-3.1303%	✅
closeShort: min	31327 gas	31327 gas	0%	🟰
closeShort: avg	131159 gas	132600 gas	-1.0867%	✅
closeShort: max	400822 gas	402622 gas	-0.4471%	✅
initialize: min	31349 gas	31349 gas	0%	🟰
initialize: avg	333404 gas	333287 gas	0.0351%	🚨
initialize: max	400023 gas	399922 gas	0.0253%	🚨
openLong: min	33370 gas	33370 gas	0%	🟰
openLong: avg	173237 gas	174232 gas	-0.5711%	✅
openLong: max	334107 gas	335241 gas	-0.3383%	✅
openShort: min	33936 gas	33936 gas	0%	🟰
openShort: avg	168484 gas	169118 gas	-0.3749%	✅
openShort: max	415043 gas	415910 gas	-0.2085%	✅
redeemWithdrawalShares: min	31251 gas	31251 gas	0%	🟰
redeemWithdrawalShares: avg	75312 gas	75250 gas	0.0824%	🚨
redeemWithdrawalShares: max	305734 gas	305633 gas	0.0330%	🚨
removeLiquidity: min	31301 gas	31301 gas	0%	🟰
removeLiquidity: avg	215168 gas	215104 gas	0.0298%	🚨
removeLiquidity: max	403861 gas	404194 gas	-0.0824%	✅

This comment was automatically generated by workflow using github-action-benchmark.