coveralls
commented
2 weeks ago Pull Request Test Coverage Report for Build 9559219588
Details
- 8 of 9 (88.89%) changed or added relevant lines in 9 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.03%) to 92.092%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| contracts/src/deployers/HyperdriveDeployerCoordinator.sol | 0 | 1 | 0.0% | ||
| <!-- | Total: | 8 | 9 | 88.89% | --> |
| Totals | |
|---|---|
| Change from base Build 9556880128: | -0.03% |
| Covered Lines: | 1968 |
| Relevant Lines: | 2137 |
github-actions[bot]
Description
This PR adds a
kindfunction to each contract that provides a human-readable way to identify a given contract. In addition to this change, the registry was updated to supportkind, and thenameandversionfields were added to any straggler contracts.Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]. If the PR doesn't touch Solidity, the corresponding checklist can be removed.[[Reviewer Name]]
approvecalls useforceApprove?transfercalls usesafeTransfer?transferFromcalls usemsg.senderas thefromaddress?call,delegatecall,staticcall,transfer,send)successboolean checked to handle failed calls?delegatecall, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecallarbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant?payablefunctions restricted to avoid stuck ether?Safefunctions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?