Closed mcclurejt closed 3 months ago
Totals | |
---|---|
Change from base Build 10638863742: | 0.0% |
Covered Lines: | 2354 |
Relevant Lines: | 2634 |
Benchmark suite | Current: 9899cfd1833755d5d502819dbae2d220b3a3ffb7 | Previous: bad6abb89b338b39fb30749fdd9008c6728bb096 | Deviation | Status |
---|---|---|---|---|
addLiquidity: min |
33812 gas |
33812 gas |
0% |
🟰 |
addLiquidity: avg |
192664 gas |
192576 gas |
0.0457% |
🚨 |
addLiquidity: max |
474677 gas |
474677 gas |
0% |
🟰 |
checkpoint: min |
40338 gas |
40338 gas |
0% |
🟰 |
checkpoint: avg |
147733 gas |
147792 gas |
-0.0399% |
✅ |
checkpoint: max |
259386 gas |
259386 gas |
0% |
🟰 |
closeLong: min |
31390 gas |
31390 gas |
0% |
🟰 |
closeLong: avg |
130194 gas |
129843 gas |
0.2703% |
🚨 |
closeLong: max |
2539405 gas |
2539405 gas |
0% |
🟰 |
closeShort: min |
31378 gas |
31378 gas |
0% |
🟰 |
closeShort: avg |
124962 gas |
124712 gas |
0.2005% |
🚨 |
closeShort: max |
277300 gas |
277300 gas |
0% |
🟰 |
initialize: min |
31356 gas |
31356 gas |
0% |
🟰 |
initialize: avg |
355878 gas |
355912 gas |
-0.0096% |
✅ |
initialize: max |
424766 gas |
424766 gas |
0% |
🟰 |
openLong: min |
33370 gas |
33370 gas |
0% |
🟰 |
openLong: avg |
173779 gas |
173599 gas |
0.1037% |
🚨 |
openLong: max |
339743 gas |
339743 gas |
0% |
🟰 |
openShort: min |
33936 gas |
33936 gas |
0% |
🟰 |
openShort: avg |
172795 gas |
172120 gas |
0.3922% |
🚨 |
openShort: max |
415077 gas |
394598 gas |
5.1898% |
🚨 |
redeemWithdrawalShares: min |
31240 gas |
31240 gas |
0% |
🟰 |
redeemWithdrawalShares: avg |
75741 gas |
76276 gas |
-0.7014% |
✅ |
redeemWithdrawalShares: max |
311190 gas |
311190 gas |
0% |
🟰 |
removeLiquidity: min |
31246 gas |
31246 gas |
0% |
🟰 |
removeLiquidity: avg |
215483 gas |
216153 gas |
-0.3100% |
✅ |
removeLiquidity: max |
403671 gas |
403671 gas |
0% |
🟰 |
This comment was automatically generated by workflow using github-action-benchmark.
Resolved Issues
Description
Review Checklists
Please check each item before approving the pull request. While going through the checklist, it is recommended to leave comments on items that are referenced in the checklist to make sure that they are reviewed. If there are multiple reviewers, copy the checklists into sections titled
## [Reviewer Name]
. If the PR doesn't touch Solidity, the corresponding checklist can be removed.[[Reviewer Name]]
approve
calls useforceApprove
?transfer
calls usesafeTransfer
?transferFrom
calls usemsg.sender
as thefrom
address?call
,delegatecall
,staticcall
,transfer
,send
)success
boolean checked to handle failed calls?delegatecall
, are there strict access controls on the addresses that can be called? It shouldn't be possible todelegatecall
arbitrary addresses, so the list of possible targets should either be immutable or tightly controlled by an admin.nonReentrant
?payable
functions restricted to avoid stuck ether?Safe
functions are altered, are potential underflows and overflows caught so that a failure flag can be thrown?