coveralls
commented
1 month ago Pull Request Test Coverage Report for Build 10623292718
Details
- 43 of 64 (67.19%) changed or added relevant lines in 10 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.6%) to 89.37%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| contracts/src/deployers/rseth-linea/RsETHLineaHyperdriveCoreDeployer.sol | 1 | 2 | 50.0% | ||
| contracts/src/deployers/rseth-linea/RsETHLineaTarget0Deployer.sol | 1 | 2 | 50.0% | ||
| contracts/src/deployers/rseth-linea/RsETHLineaTarget1Deployer.sol | 1 | 2 | 50.0% | ||
| contracts/src/deployers/rseth-linea/RsETHLineaTarget2Deployer.sol | 1 | 2 | 50.0% | ||
| contracts/src/deployers/rseth-linea/RsETHLineaTarget3Deployer.sol | 1 | 2 | 50.0% | ||
| contracts/src/deployers/rseth-linea/RsETHLineaTarget4Deployer.sol | 1 | 2 | 50.0% | ||
| contracts/src/instances/rseth-linea/RsETHLineaBase.sol | 13 | 17 | 76.47% | ||
| contracts/src/deployers/rseth-linea/RsETHLineaHyperdriveDeployerCoordinator.sol | 16 | 27 | 59.26% | ||
| <!-- | Total: | 43 | 64 | 67.19% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| contracts/src/libraries/LPMath.sol | 1 | 84.39% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 10621797190: | -0.6% |
| Covered Lines: | 2354 |
| Relevant Lines: | 2634 |
github-actions[bot]
Description
This PR adds support for Kelp DAO's rsETH yield source on Linea. This was a pretty standard LRT yield source, but there are a few things for reviewers to think about:
wrsETH, but it is redeemable 1:1 with rsETH. rsETH seems like it has more name recognition, but it's worth thinking about. We could also call thisWrsETHHyperdrive.asBase = truewhen the fees are zero? We could just rip this logic out if we wanted to.