coveralls
commented
2 months ago Pull Request Test Coverage Report for Build 11282077538
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 150 of 168 (89.29%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.02%) to 88.885%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| contracts/src/libraries/UniV3Path.sol | 2 | 4 | 50.0% | ||
| contracts/src/zaps/UniV3Zap.sol | 148 | 164 | 90.24% | ||
| <!-- | Total: | 150 | 168 | 89.29% | --> |
| Totals | |
|---|---|
| Change from base Build 11261243207: | 0.02% |
| Covered Lines: | 2639 |
| Relevant Lines: | 2969 |
github-actions[bot]
Description
This PR adds a zap contract that supports generalized swapping between assets using Uniswap V3. Each Hyperdrive trading or LP function has a direct anologue in the zap contract that exposes all of the parameters as well as a few extra parameters for things like the Uniswap swap object (
ISwapRouter.ExactInputParams) and special-case parameters to handle different edge-cases in the zap.Extensive tests were added that should test the different paths through these functions. Special care was taken to verify that ETH, WETH, and rebasing tokens are properly handled by the zap contract. Since Uniswap v3 doesn't really support ETH as a first-class citizen in all situations, there are several flows within the zap contract where ETH will be converted to WETH or vice-versa. For the most part, this is unopinionated and will support all use-cases, but in the case of zapping funds out of the zap, WETH will always be unwrapped into ETH before sending it to the user.
Some notable things to watch out for are:
openShortZap's lack of precision compared to the other flows. This is unavoidable because of the way that Hyperdrive'sopenShortlogic functions.